[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://insserv/{insserv.templates}



Please find, for review, the debconf templates and packages descriptions for the insserv source package.

This review will last from Monday, January 21, 2008 to Thursday, January 31, 2008.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:
--- ../insserv.old/debian/insserv.templates	2008-01-14 08:33:57.464460021 +0100
+++ debian/insserv.templates	2008-01-17 07:22:28.205536032 +0100
@@ -1,20 +1,16 @@
 Template: insserv/enable
 Type: boolean
-_Description: Enable (or keep enabled) dependency based boot sequence?
- Enabling this will reorder all the scripts in /etc/rc*.d/ using the
- dependency information provided in each script.  If such information
- is missing, default dependency info will be used.  It will also
- change all S* symlinks in rc0.d/ and rc6.d/ to K* symlinks, to make
+_Description: Enable (or keep enabled) the dependency-based boot sequence?

Join words with an hyphen


+ If you choose to enable the dependency-based boot sequence,
+ all the scripts in /etc/rc*.d/ that use dependency information will be
+ reordered. If such information
+ is missing, default dependency info will be used. All S* symlinks in rc0.d/
+ and rc6.d/ will be turned into K* symlinks, to make
  sure the way they are used (with 'stop' argument) matches their
- names.  The change will only be done after it is verified that it is
- safe to convert.  Disabling it when enabled will try to revert the
+ names. The change will only be done after it is verified that it is
+ safe to convert. Disabling it when enabled will try to revert the
  change.

"If you choose to"....common wording in such situation....and slightly
more neutral wording.

Repeeating what is to be enabled makes the long description
independent from the synopsis.

Double spaces removed (overall consistency)


  .
- WARNING: It is very hard to revert from dependency based boot
- sequencing to the non-dependency based boot sequencing.
- Reinstallation might be required.
- .
- This is an experimental feature, and is at the moment only intended
- for testing of insserv and the LSB style dependecy information in
- init.d scripts.
-
+ Please note that this feature is experimental. Reverting from
+ dependency-based boot sequencing is not supported and may require the
+ reinstallation of the system.

Big "WARNING" are discouraged (yeah, I know, this is experimental, but
saying so should be enough).

Both paragraphs condensed in one and shortened. I think that it still
says what's needed.


--- ../insserv.old/debian/control	2008-01-14 08:33:57.464460021 +0100
+++ debian/control	2008-01-17 07:24:29.005543353 +0100
@@ -12,10 +12,10 @@
 Depends: ${shlibs:Depends}, ${misc:Depends}, sysv-rc
 Suggests: bootchart
 Conflict: initscripts (<< 2.86.ds1-48)
-Description: Reorder boot sequence based on LSB init.d script dependencies
- Reorder the boot order based on init.d script dependencies as
- documented in LSB comment headers in the script or in override files
- included in the package or in /etc/.
+Description: boot sequence ordering based on LSB init.d script dependencies

Do not make a sentence in the synopsis


+ This utility reorders the init.d boot scripts based on dependencies
+ mentioned in scripts' LSB comment headers or override files
+ included in this package or in /etc/.

Make full sentences in the long description, however.

Included in *this* package is my understanding. I hope I'm correct.

  .
- Use this package with care, as incorrect or missing dependencies can
- give you an unbootable system.
+ This package should be used with care, as incorrect or missing dependencies
+ can lead to an unbootable system.

More neutral wording.

-- 


Template: insserv/enable
Type: boolean
_Description: Enable (or keep enabled) the dependency-based boot sequence?
 If you choose to enable the dependency-based boot sequence,
 all the scripts in /etc/rc*.d/ that use dependency information will be
 reordered. If such information
 is missing, default dependency info will be used. All S* symlinks in rc0.d/
 and rc6.d/ will be turned into K* symlinks, to make
 sure the way they are used (with 'stop' argument) matches their
 names. The change will only be done after it is verified that it is
 safe to convert. Disabling it when enabled will try to revert the
 change.
 .
 Please note that this feature is experimental. Reverting from
 dependency-based boot sequencing is not supported and may require the
 reinstallation of the system.
--- ../insserv.old/debian/insserv.templates	2008-01-14 08:33:57.464460021 +0100
+++ debian/insserv.templates	2008-01-17 07:22:28.205536032 +0100
@@ -1,20 +1,16 @@
 Template: insserv/enable
 Type: boolean
-_Description: Enable (or keep enabled) dependency based boot sequence?
- Enabling this will reorder all the scripts in /etc/rc*.d/ using the
- dependency information provided in each script.  If such information
- is missing, default dependency info will be used.  It will also
- change all S* symlinks in rc0.d/ and rc6.d/ to K* symlinks, to make
+_Description: Enable (or keep enabled) the dependency-based boot sequence?
+ If you choose to enable the dependency-based boot sequence,
+ all the scripts in /etc/rc*.d/ that use dependency information will be
+ reordered. If such information
+ is missing, default dependency info will be used. All S* symlinks in rc0.d/
+ and rc6.d/ will be turned into K* symlinks, to make
  sure the way they are used (with 'stop' argument) matches their
- names.  The change will only be done after it is verified that it is
- safe to convert.  Disabling it when enabled will try to revert the
+ names. The change will only be done after it is verified that it is
+ safe to convert. Disabling it when enabled will try to revert the
  change.
  .
- WARNING: It is very hard to revert from dependency based boot
- sequencing to the non-dependency based boot sequencing.
- Reinstallation might be required.
- .
- This is an experimental feature, and is at the moment only intended
- for testing of insserv and the LSB style dependecy information in
- init.d scripts.
-
+ Please note that this feature is experimental. Reverting from
+ dependency-based boot sequencing is not supported and may require the
+ reinstallation of the system.
--- ../insserv.old/debian/control	2008-01-14 08:33:57.464460021 +0100
+++ debian/control	2008-01-17 07:24:29.005543353 +0100
@@ -12,10 +12,10 @@
 Depends: ${shlibs:Depends}, ${misc:Depends}, sysv-rc
 Suggests: bootchart
 Conflict: initscripts (<< 2.86.ds1-48)
-Description: Reorder boot sequence based on LSB init.d script dependencies
- Reorder the boot order based on init.d script dependencies as
- documented in LSB comment headers in the script or in override files
- included in the package or in /etc/.
+Description: boot sequence ordering based on LSB init.d script dependencies
+ This utility reorders the init.d boot scripts based on dependencies
+ mentioned in scripts' LSB comment headers or override files
+ included in this package or in /etc/.
  .
- Use this package with care, as incorrect or missing dependencies can
- give you an unbootable system.
+ This package should be used with care, as incorrect or missing dependencies
+ can lead to an unbootable system.
Source: insserv
Section: misc
Priority: optional
Maintainer: Petter Reinholdtsen <pere@debian.org>
Build-Depends: debhelper (>= 4.0.0), po-debconf, dpatch
Standards-Version: 3.7.3
Vcs-Svn: svn://svn.debian.org/initscripts-ng/trunk/src/insserv
Vcs-Browser: http://svn.debian.org/wsvn/initscripts-ng/trunk/src/insserv

Package: insserv
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, sysv-rc
Suggests: bootchart
Conflict: initscripts (<< 2.86.ds1-48)
Description: boot sequence ordering based on LSB init.d script dependencies
 This utility reorders the init.d boot scripts based on dependencies
 mentioned in scripts' LSB comment headers or override files
 included in this package or in /etc/.
 .
 This package should be used with care, as incorrect or missing dependencies
 can lead to an unbootable system.

Attachment: signature.asc
Description: Digital signature


Reply to: