Re: [RFR] templates://tipcutils/{templates}

[Martin Peylo <debian@izac.de>]

Hi,

thanks for your help, I'm totally fine with all your changes. Please  
find my input to the open issues inline.

On 05.01.2008, at 21:14, Justin B Rye wrote:

> Christian Perrier wrote:
> > Your review should be sent as an answer to this mail.
>
> >  Template: tipcutils/remote_management
> [...]
> > +_Description: TIPC remote management:
> > + If you want to disable network management for this node, please  
> > enter
> > + 'disable' here.
> >
> > That one is tricky. I think you should use a boolean template here  
> > but
> > that goes quite outside the scope of the review as dealing with this
> > would need maintainer scripts changes. You should consider turning
> > this into a boolean template.
> >
> > The use of sentences like "if you don't know what to do...." is
> > discouraged as well. The user is supposed to have some knowledge.
>
> If it's the default, do users need to "enter" it?  Maybe:
>
>     Only modify this value to 'enable' if you are sure network
>     management should be enabled for this node.
>
> (This also clarifies that the alternative *is* "enable".  Assuming
> it is...)

You're right - I'll change this to boolean in the next release.

> Control file:
> >  Package: tipcutils
> [...]
> >  Description: TIPC utilities package
>
> s/package//
>
> > - Configures and manages the TIPC 1.6 (Transparent Inter Process  
> > Communication)
> > - kernel module.
> > + This package provides tools and scripts to configure and manage  
> > the TIPC
> > + 1.6 (Transparent Inter Process Communication) kernel module.
> >
> > I would recommend describing what TIPC is. Assuming that "if ppl do
> > not know what this is, they don't need it" is IMHO not enough. After
> > all, FLOSS is a matter of learning, also.
>
> Is the version number required?  There's a TPC 1.7.4 on the
> homepage... how about:
>
>     This package provides tools and scripts to configure and manage  
> the TIPC
>     Linux kernel module, used for Transparent Inter Process  
> Communication
>     within clusters.

The version number is required as this version of tipc-config is  
(said by the developers to be) not compatible with TIPC 1.7. While it  
is not be that much of a problem so far since one has to do some  
extra work to have TIPC 1.7 installed, it will be upgraded in the  
Kernel within the next year. I'm still not sure how to cope with that  
but I fear, there has to be an extra package for tipcutils 1.1.x.  
I'll have to check if it is possible to make it downwards compatible  
but let's assume for now that it is not.

What about something like:

  This package provides tools and scripts to configure and manage  
the TIPC
  1.6 (Transparent Inter Process Communication) kernel module.
  .
  TIPC is designed for use in clustered computer environments,  
allowing to
  create applications that can communicate quickly and reliably with  
other
  applications regardless of their location within the cluster.
  .
  The TIPC 1.6 kernel module is included in the offical kernel since  
version
  2.6.16. Please note that this version is not compatible with TIPC  
1.7.


Best regards,
Martin