Re: [RFR] templates://tipcutils/{templates}
Hi,
thanks for the review, I am fine with all of your changes. Here my
input to the open issues.
Rationale:
--- ../tipcutils.old/debian/templates 2008-01-01 12:48:57.719332464
+0100
+++ debian/templates 2008-01-05 14:39:13.387252526 +0100
@@ -1,6 +1,7 @@
Template: tipcutils/configure
Type: boolean
Default: true
+# Not rewritten as debconf abuse
_Description: Configure this TIPC node now?
In case you don't know what TIPC is you most probably installed
the package "tipcutils" by accident. As it is a very special
network protocol
This template is IMHO debconf abuse. Asking whether one wants to
configure a package while the package was installed is kinda
redundant.
Whether or not the package was installed "by accident" should not be
an argument, otherwise each package would ask such a question.
While you're right about the installing "by accident", the user
should be able to decide if he wants have the node configured by the
scripts or manually. What about something like:
Do you want to configure TIPC now?
.
In case you want to configure the node manually, please edit
'/etc/default/tipc'. You can also use the command line tool
'tipc-config' to change the TIPC runtime settings.
Template: tipcutils/remote_management
Type: string
Default: disable
-_Description: Enable/disable TIPC remote management for this node:
- In case you don't know what this is keep it disabled!
+_Description: TIPC remote management:
+ If you want to disable network management for this node, please
enter
+ 'disable' here.
That one is tricky. I think you should use a boolean template here but
that goes quite outside the scope of the review as dealing with this
would need maintainer scripts changes. You should consider turning
this into a boolean template.
I will change this into boolean in the next release.
More in the mail I'll send as reply to Justin's.
Best regards,
Martin
Reply to: