[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://tipcutils/{templates}



Christian Perrier wrote:
> Your review should be sent as an answer to this mail.

>  Template: tipcutils/remote_management
[...]
> +_Description: TIPC remote management:
> + If you want to disable network management for this node, please enter
> + 'disable' here.
> 
> That one is tricky. I think you should use a boolean template here but
> that goes quite outside the scope of the review as dealing with this
> would need maintainer scripts changes. You should consider turning
> this into a boolean template.
> 
> The use of sentences like "if you don't know what to do...." is
> discouraged as well. The user is supposed to have some knowledge.

If it's the default, do users need to "enter" it?  Maybe:

    Only modify this value to 'enable' if you are sure network
    management should be enabled for this node.

(This also clarifies that the alternative *is* "enable".  Assuming
it is...)

>  Template: tipcutils/default_ndd
[...]
> +_Description: Default neighbour detection domain for this TIPC node:
> + This setting will define the neighbour detection domain if there is
> + no setting for a specific bearer.

Throughout, en_USify: s/neighbour/neighbor/.

Control file:
>  Package: tipcutils
[...]
>  Description: TIPC utilities package

s/package//

> - Configures and manages the TIPC 1.6 (Transparent Inter Process Communication) 
> - kernel module.
> + This package provides tools and scripts to configure and manage the TIPC
> + 1.6 (Transparent Inter Process Communication) kernel module.
> 
> I would recommend describing what TIPC is. Assuming that "if ppl do
> not know what this is, they don't need it" is IMHO not enough. After
> all, FLOSS is a matter of learning, also.

Is the version number required?  There's a TPC 1.7.4 on the
homepage... how about: 

    This package provides tools and scripts to configure and manage the TIPC
    Linux kernel module, used for Transparent Inter Process Communication
    within clusters.
-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
--- ../tipcutils.old/debian/templates	2008-01-01 16:49:58.000000000 +0000
+++ debian/templates	2008-01-05 19:58:07.000000000 +0000
@@ -1,6 +1,7 @@
 Template: tipcutils/configure
 Type: boolean
 Default: true
+# Not rewritten as debconf abuse
 _Description: Configure this TIPC node now?
  In case you don't know what TIPC is you most probably installed
  the package "tipcutils" by accident. As it is a very special network protocol
@@ -12,41 +13,45 @@
 Template: tipcutils/address
 Type: string
 Default: 1.1.1
-_Description: The TIPC address of this node:
- The TIPC address is written in Z.C.N (Zone.Cluster.Node) notation.
+_Description: TIPC address of this node:
+ Please enter the TIPC address of this node, in Z.C.N (Zone.Cluster.Node)
+ notation.
  .
- Make sure all nodes in your network have different addresses!
+ You should use different addresses for all nodes in the same network.
 
 Template: tipcutils/netid
 Type: string
 Default: 4711
-_Description: The Network ID of the TIPC Network this node shall join:
- In case there is just one TIPC Network, keep the default!
+_Description: Network ID of the TIPC network to join:
+ The default setting should be appropriate when there is only
+ one local TIPC network.
 
 Template: tipcutils/remote_management
 Type: string
 Default: disable
-_Description: Enable/disable TIPC remote management for this node:
- In case you don't know what this is keep it disabled!
+_Description: TIPC remote management:
+ Only modify this value to 'enable' if you are sure network         
+ management should be enabled for this node.         
 
 Template: tipcutils/default_ndd
 Type: string
 Default: 0.0.0
-_Description: The default Neighbour Detection Domain for this TIPC node:
- If there is no setting for a specific bearer this will be used as the Neighbour
- Detection Domain. Setting a NDD for a specific bearer is not yet possible in
- this package version.
+_Description: Default neighbor detection domain for this TIPC node:
+ This setting will define the neighbor detection domain if there is
+ no setting for a specific bearer.
  .
- In case you don't know what this is keep the default!
+ Setting a NDD for a specific bearer is not yet possible in
+ this package version.
 
 Template: tipcutils/interfaces
 Type: string
 Default: eth0
-_Description: The interfaces to use for TIPC:
- A space separated list of the interfaces to be used for TIPC.
+_Description: Interfaces to use for TIPC:
+ Please enter a space-separated list of interfaces to be used for TIPC.
 
 Template: tipcutils/script_verbosity
 Type: string
 Default: 0
-_Description: The verbosity to use for TIPC scripts:
- Defines the verbosity of the init, if-up and if-down scripts.
+_Description: Verbosity to use for TIPC scripts:
+ This setting defines the verbosity of the TIPC init, if-up and if-down
+ scripts.
--- ../tipcutils.old/debian/control	2008-01-01 16:49:59.000000000 +0000
+++ debian/control	2008-01-05 20:03:50.000000000 +0000
@@ -9,6 +9,7 @@
 Package: tipcutils
 Architecture: any
 Depends: ${shlibs:Depends}, ${misc:Depends}, lsb-base, ifupdown, net-tools
-Description: TIPC utilities package
- Configures and manages the TIPC 1.6 (Transparent Inter Process Communication) 
- kernel module.
+Description: TIPC utilities
+ This package provides tools and scripts to configure and manage the TIPC
+ Linux kernel module, used for Transparent Inter Process Communication
+ within clusters.
Template: tipcutils/configure
Type: boolean
Default: true
# Not rewritten as debconf abuse
_Description: Configure this TIPC node now?
 In case you don't know what TIPC is you most probably installed
 the package "tipcutils" by accident. As it is a very special network protocol
 you most probably don't need you might want to consider uninstalling it.
 .
 If you don't want to configure TIPC now, you can edit the configuration file 
 /etc/default/tipc later.

Template: tipcutils/address
Type: string
Default: 1.1.1
_Description: TIPC address of this node:
 Please enter the TIPC address of this node, in Z.C.N (Zone.Cluster.Node)
 notation.
 .
 You should use different addresses for all nodes in the same network.

Template: tipcutils/netid
Type: string
Default: 4711
_Description: Network ID of the TIPC network to join:
 The default setting should be appropriate when there is only
 one local TIPC network.

Template: tipcutils/remote_management
Type: string
Default: disable
_Description: TIPC remote management:
 Only modify this value to 'enable' if you are sure network         
 management should be enabled for this node.         

Template: tipcutils/default_ndd
Type: string
Default: 0.0.0
_Description: Default neighbor detection domain for this TIPC node:
 This setting will define the neighbor detection domain if there is
 no setting for a specific bearer.
 .
 Setting a NDD for a specific bearer is not yet possible in
 this package version.

Template: tipcutils/interfaces
Type: string
Default: eth0
_Description: Interfaces to use for TIPC:
 Please enter a space-separated list of interfaces to be used for TIPC.

Template: tipcutils/script_verbosity
Type: string
Default: 0
_Description: Verbosity to use for TIPC scripts:
 This setting defines the verbosity of the TIPC init, if-up and if-down
 scripts.
Source: tipcutils
Section: admin
Priority: optional
Maintainer: Martin Peylo <debian@izac.de>
Build-Depends: debhelper (>= 5), linux-libc-dev (>= 2.6.21-2), po-debconf
Standards-Version: 3.7.3
Homepage: http://tipc.sourceforge.net

Package: tipcutils
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, lsb-base, ifupdown, net-tools
Description: TIPC utilities
 This package provides tools and scripts to configure and manage the TIPC
 Linux kernel module, used for Transparent Inter Process Communication
 within clusters.

Reply to: