[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://slim/{slim.templates}

Christian Perrier <bubulle@debian.org> wrote:
> Quoting MJ Ray (mjr@phonecoop.coop):
> > What check for a default display manager?  This check or another check?
> The templates file should be identical to the xdm|kdm|gdm templates
> file.
> See attached proposed file...taken from xdm. It has already been
> reviewed, so the maintainer *must* use that template..:-)

By the way, apologies for not sending udiffs earlier.  I haven't
automated my bit of the review process yet.  They're below now.

So xdm's template (and any others copied) still has two bugs:

1. this is not selecting which one runs "by default" is it?  It seems
like it's selecting which one is the first choice.  The one that runs
"by default" is the fall-back, the last choice, which I suspect is
x-terminal-emulator or similar. If in doubt, look up what "to default"

2. Question remains: what check?  This check?  Another check?  All checks?
Using "the" doesn't make sense to me here.  On second reading, I think it
means all checks in the relevant init scripts.

Also, looking at the archives now I'm not on a train, xdm seems to
have gone straight from Intent To Review to Last Call For Comments
in March 2007 - when was the Request For Review?

Anyway, if a buggy template is uneditable, please don't send it for a
review and waste my time.

--- slim.templates.orig	2007-05-10 11:01:17.000000000 +0100
+++ slim.templates	2007-05-10 10:59:28.000000000 +0100
@@ -7,7 +7,7 @@
  Only one display manager can manage a given X server, but multiple display
  manager packages are installed.  Please select which display manager should
- run by default.
+ be the preferred choice.
  (Multiple display managers can run simultaneously if they are configured to
  manage different servers; to achieve this, configure the display managers
--- control.slim.orig	2007-05-10 11:01:31.000000000 +0100
+++ control.slim	2007-05-10 11:02:17.000000000 +0100
@@ -10,8 +10,8 @@
 Provides: x-display-manager
 Depends: ${shlibs:Depends}, debconf (>= 1.2.9) | debconf-2.0
 Description: Desktop-independent graphical login manager for X11
- SLiM aims to be light and simple, although completely configurable through 
- themes and an option file. It is particularly suitable for machines don't 
- require remote logins.
+ SLiM aims to be light and simple, yet completely configurable through 
+ themes and an option file. It is particularly suitable for machines that 
+ don't require remote logins.
  Homepage: http://slim.berlios.de/
My Opinion Only: see http://people.debian.org/~mjr/
Please follow http://www.uk.debian.org/MailingLists/#codeofconduct

Reply to: