Bug#604096: Bug#601341: Bug#602418: #601341, #602418 and #604096 seem to be duplicates

[Ian Campbell <ijc@hellion.org.uk>]

Hi Konrad,

On Tue, 2010-12-07 at 11:47 -0500, Konrad Rzeszutek Wilk wrote:
> On Tue, Dec 07, 2010 at 11:49:14AM +0000, Ian Campbell wrote:
> > Is the series at https://lkml.org/lkml/2010/12/6/516  sufficient in its
> > own right to make Nouveau and ATI work or is more needed? What about NV?
> 
> Both Nouveau and ATI (PCIe) look to work. I did light testing (ATI ES1000,
> Radeon 3450, Nvidia 65.. something) and will need to do some more
> aggressive ones. Oh, and Intel GTT seems to work without any of these
> patches - but I've only tested it on a machine with 4GB so I need to add
> more memory to make sure.

I decided to try backporting this series to the 2.6.32 + DRM form 2.6.33
tree which is used in Squeeze (maintained in
git://git.kernel.org/pub/scm/linux/kernel/git/smb/linux-2.6.32.y-drm33.z.git).

This was reasonably non-trivial for the first few commits in the series
because 1403b1a38e8b "drm/ttm: add pool wc/uc page allocator V3" is not
present in this tree but I think I managed to do the right thing (I
might run the patch by you once I've run it up on my machine, if that's
ok with you)

Then I got to eba164ec7e69 "radeon/nouveau/ttm/AGP: Use dma_addr if TTM
has set it." which complained:
          CC [M]  drivers/gpu/drm/ttm/ttm_agp_backend.o
        drivers/gpu/drm/ttm/ttm_agp_backend.c: In function ‘ttm_agp_populate’:
        drivers/gpu/drm/ttm/ttm_agp_backend.c:66: error: ‘struct agp_memory’ has no member named ‘dma_addr’
and indeed the field is missing both in 2.6.32+drm33 and Linus' tree. Do
I need to cherry pick something from another series or is this commit
something which should be ignored per our previous discussion about PCIe
vs AGP etc? (I'm going with the second option for now) 

I'll publish my backport in a git tree once I'm happy with it, I need to
tidy it up and correct the cherry-picked from comments etc and then
actually build something which uses it. I'll make Debian packages
available for wider testing once I've done that (with Xmas coming up I
don't know when that will actually be).

Did the series make any waves upstream? What are the chances that it
will go upstream in something roughly like its current form?

Thanks,
Ian.

-- 
Ian Campbell
Current Noise: Angelcorpse - Reap The Whirlwind

Collaboration, n.:
	A literary partnership based on the false assumption that the
	other fellow can spell.