Re: RFS: javax.persistence/2.1.0.v201304241213-1
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi Emmanuel,
Thanks for the review. The maintenance was an oversight, which I've now
fixed. I've also added the debug flag to the javac task. I like your
suggested package naming, so I've renamed the source package to
eclipselink-jpa-2.1-spec and the binary to libjpa-2.1-spec-java.
The git repository is now at:
Vcs-Browser:
http://anonscm.debian.org/gitweb/?p=pkg-java/eclipselink-jpa-2.1-spec.git
Vcs-Git: git://anonscm.debian.org/pkg-java/eclipselink-jpa-2.1-spec.git
Once Geronimo releases a 2.1 spec then we can probably swap to that I guess.
Thanks,
Andy
On 04/10/13 21:49, Emmanuel Bourg wrote:
> Hi Andrew,
>
> I reviewed the package and it looks good.
>
> One minor detail, since you used javahelper the debug symbols are not
> included by default in the compiled classes as required by the Java
> policy (we really need a lintian check to detect this). That's not
> critical for JPA since it mostly consists in interfaces.
>
> The maintenance isn't assigned to the Debian Java Maintainers, is this
> intentional?
>
> Regarding the name of the package, maybe something like libjpa2.1-java
> or jpa-2.1-spec would be more in line with the other JEE spec packages
> already in Debian (like libservlet3.0-java or portlet-api-2.0-spec).
>
>
>> I looked at packaging the Geronimo spec for JPA2.1 but it seems they
>> haven't released one, so this is the spec which needs to be used I think.
>
> It seems it will be included in the next release of Geronimo:
>
> https://issues.apache.org/jira/browse/GERONIMO-6451
>
> There is a a patch attached that adds the JPA 2.1 methods.
>
>
> Emmanuel Bourg
>
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iQIcBAEBAgAGBQJST+wYAAoJEJ0xLSYlIEOZiVcP/1auD++rZHaFORT8TKP4W7US
Y/Kt/jG9o/y/vSrLvcOe2mg8gooNCXwBodoQWAVWhc7yGczaMo0ZSHS2pEj50EsR
3+UzwNBzGQKy1udWNhboffNp01JscH3j5qBK1E0x4ITAGNRp19pbsLTr5fdcnLxd
95tONtAYD5Xu7b590VBefJnB3DI+1yJ4AT7jOtTmYPeUnVh/epC7JxnxaNAcMlKk
ERjLR51mXMUmkQzVbOEk0fgQNpnDfiyjT2aGVD/x9o2hLnt84MJ0s0y8qe8qK5GX
3aEb2JXUOo9Z38hmEtJpBq+s94I4ptvIqTFnKnj1G0x+4L0krS9Ji0wtctugLS1t
h37cfyzbBAK7QGaIk2SJCQb+gu2iXfZEjb7iRJx3JlkSD8TDO76hPXR4MVBws+Ai
dvhm8FOjKGenjZ4wsFZdXkpyeMSGb5dwnNeSI4Pv0TpNgE8hTtSjoleh2dt2DNHh
I5ew604YtbcOuVp0vV8euLR7SI69x0DD3OW2vPmbK5fvIfWFW9B5iNJKHGIuhXES
JvFfFDPMI4u0zesFyG1suR/vvvFMIckCi4Yo0Am8Bd66m0RmfchxGXyx0wC/qyiy
vJloITLEXaLbY0qxjGillyLm5N1Z2f63gx+aSs0cVbITdyWZ9jFoef3R0As2M8YN
LA4rX3uMh1X4y/W1ofGq
=q4md
-----END PGP SIGNATURE-----
Reply to: