Re: RFS: sunflow
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 29/01/2010 21:03, Gabriele Giacone wrote:
> I am looking for a sponsor for my package "sunflow".
>
> * Package name : sunflow
[...]
> I would be glad if someone reviewed and possibly uploaded this package
> for me.
Here we go !
[Hi Cyril! I've CCed you if you want to add some comments]
debian/copyright:
missing "(C) 2006 by Mad Crew" from
exporters/maya/sunflowExporter/src/skylight.cpp
exporters/maya/sunflowExporter/src/sunskyConstants.h
exporters/maya/sunflowExporter/src/skylight.h
debian/control:
- - I'm not sure about your move "Section: from graphics to java", but YMMV.
- - I'm not really found of "Removed VCS fields" item :) AFAIK, sunflow is
in in collab-maint [1] and I tend to prefer package to be maintained in
some sort of $VCS (Gabriele, we already had this discussion :). You can
request account on Alioth Collab-Maint [2]
debian/patches/20_disable_wheel_movement:
Can you explain what was your build failure with this method ?
(and, by the way, add this explenation to patch header)
#addMouseWheelListener() exist in Java API since 1.4
debian/rules:
- - You are using debian/docs and dh_install release/javadoc/*
usr/share/doc/sunflow/html : you should make a choice
- - You should register your docs with doc-base
- - ... but I don't think there added value by providing Javadoc for Java
applications
[1] http://git.debian.org/?p=collab-maint/sunflow.git
[2] http://wiki.debian.org/Alioth/Git
Cheers,
- --
Damien Raude-Morvan - http://damien.raude-morvan.com/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAktjc9sACgkQyIFXyIXHk4lqIwCguoy/9g91ZKzp4IbwyBKlWmsd
ABEAnRGb3efjKid9SaBV9ZDxlxf8Qb7x
=ESrB
-----END PGP SIGNATURE-----
Reply to: