[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: libnanoxml2-java (updated package)

On Fri Jan 29 14:11, Sveinung Kvilhaugsvik wrote:
> Dear mentors,
> I am looking for a sponsor for the new version 2.2.3.dfsg-3
> of my package "libnanoxml2-java".

Hi, I'm looking over the package now. There's a couple of things (which aren't
new, but should probably be changed either in this or the next upload. Yes, 
I'm aware I sponsored the last one...):

 - I doubt you want default-jdk-builddep, that pulls in GCJ for building -gcj
 packages (yes, it's badly named). You probably want default-jdk
 - If you are build-depending on default-jdk, why are you then depending on
 - shouldn't you also depend on java5 and java6 virtual packages in the
 alternate depends?

(and just a style point):

 - you should probably have a look at the dh 7 integration with javahelper, and

However, I can't upload this version even ignoring that, since it doesn't build
with the latest version of javahelper, as jh_build now calls javadoc by
default, so you need to pass in "--javadoc-opts=-source 1.4" (or --no-javadoc).


Matthew Johnson

Attachment: signature.asc
Description: Digital signature

Reply to: