Re: Some names are missing from the list of translators
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Thomas Huriaux wrote:
> Luk Claes <luk@debian.org> (13/11/2005):
>
>>Daniel Nylander wrote:
>>
>>>Thomas Huriaux skrev:
>>>
>>>
>>>
>>>>>but the name doesn't show up in the list.
>>>>>
>>>>>
>>>>
>>>>Some of the files (such as pileup, atftp etc..) include my name
>>>>
>>>>
>>>>These files are of dos type, so the line
>>>>"Last-Translator: Daniel Nylander <po@danielnylander.se>\n"\r
>>>>does not match the regexp
>>>>^"Last-Translator:\s*(.*)\\n"$
>>>>(\r\n instead of \n at the end of each line)
>>>>
>>>>
>>>
>>>
>>>Hmm, weird. I used the same editor as I did for many others
>>>(gtranslator, poedit, kbabel).
>>>Is there any chance you might change the regexp to include even these
>>>types of formated files?
>>>(or shall I bugreport all translations again and wait a few weeks? :-))
>>
>>I added a .* after \\n, so no need to bug all translators who use EOLs
>>that don't end with \n :-)
>
>
> I've fixed it as following (in the dl10n cvs):
> - if (m/^"Last-Translator:\s*(.*)\\n"$/m) {
> + if (m/^"Last-Translator:\s*(.*)\\n"\r?$/m) {
>
> Luk, I don't know where you have fixed it, but the .* should be added
> after the " and not before. I also prefer to limit it to \r? and not .*.
I don't see any reason to put it behind the ", nor do I understand why
you want to limit it to "\r?", maybe we should change it so that all
common EOLs are supported: \n, \r and \n\r?
If you want to limit it to \r, did you check if your expression works as
I'm not sure if it there shouldn't be an extra "\" ...
Cheers
Luk
- --
Luk Claes - http://people.debian.org/~luk - GPG key 1024D/9B7C328D
Fingerprint: D5AF 25FB 316B 53BB 08E7 F999 E544 DE07 9B7C 328D
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
iD8DBQFDd3qM5UTeB5t8Mo0RAiS3AJ0XcMdtk+pu4sY+5pzv/Jm0I14lzgCePpT8
nPqClMJEWKVHzBcm2canFEE=
=VD2m
-----END PGP SIGNATURE-----
Reply to: