[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Pkg-ofed-devel] RFS: qperf

Hi Afif,

Thanks for your feedback. I've made the changes that you suggested.

Also, I've changed the upstream source to the linux-rdma github repository and updated the code to 0.4.10.

Regarding the copyright, BSD should not have been in there and has been removed. COPYING is identical to /usr/share/common-licenses/GPL-2. The GPL-2 license section in copyright now contains the GPL-2 notice and a pointer to /usr/share/common-licenses/GPL-2. Please let me know if that is not the right thing to do.

Thanks, again!

Brian T. Smith
System Fabric Works
Senior Technical Staff
(512) 293-4472

On Thu, Nov 9, 2017 at 11:56 PM, Afif Elghraoui <afif@debian.org> wrote:

على الخميس  9 تشرين الثاني 2017 ‫11:19، كتب Brian Smith:
> Hello Afif,
> Sorry for cross-posting. I wasn't sure if the forwarding from pkg-ofed
> is yet configured.

No worries. It turns out not to be the reason why I'm getting duplicate
messages, so I'm restoring the cross-posting.

> To answer your question, I am subscribed to debian-hpc.

Ok, so I can just reply-list now. :)

> I really appreciate your reviewing the qperf package and look forward
> to your feedback. Thanks!

Here we go.


> Depends: ${misc:Depends},
>  ${shlibs:Depends},
>  libibverbs1,
>  librdmacm1

${shlibs:Depends} will handle the shared library dependencies for you,
along with minimal versions where possible. You shouldn't set those
shared library dependencies manually unless absolutely necessary. If I
build after removing those two explicit lines, I get the final package
appropriately having:

Depends: libc6 (>= 2.15), libibverbs1 (>= 1.1.6), librdmacm1 (>= 1.0.19)

With debhelper compat 10, parallel and autoreconf are enabled by default
[1], so you can simply use `dh $@`.

The changelog gets updated once per upload. Everything as of now is part
of the initial release, so you should just get rid of the everything
else there. I'll change the target distribution once it's ready to go,
right before I build the version to upload.

* The source code indicates GPL 2, not GPL 2+. You have correctly
labeled it GPL-2, but the text you included has the "or (at your option)
any later version" clause. That should be removed for this package.

* The BSD option is for a 2-clause license, not 3. Please correct this;
and it's best to use the exact wording they give for the license text.

Since the debian/tests/control file here defines no tests, I don't see a
reason for this directory to exist.

The NEWS file is empty; I wouldn't install an empty file.

Everything else looks good to me. Let me know when I should have another
look--and no need to upload to mentors; I'm working with the git
repository. Thanks for working on this package!


1. https://lists.debian.org/debian-devel/2016/04/msg00018.html

Afif Elghraoui | عفيف الغراوي

Pkg-ofed-devel mailing list

Reply to: