[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: New version of haskell-tagsoup ready for upload.



Hi Erik.

Excerpts from Marco Túlio Gontijo e Silva's message of Qua Jun 02 08:16:15 -0300 2010:
(...)
> I'm uploading it.

Actually, I just noticed some other thing: The cabal build-depends is:

>From tagsoup-0.9/tagsoup.cabal:
(...)
> build-depends: QuickCheck == 2.1.*, (...) deepseq == 1.1.0.0, (...)

And your Build-Depends: is:

>From tagsoup-0.9/debian/control:
(...)
 libghc6-quickcheck2-dev (>= 2.1),
(...)
 libghc6-deepseq-dev (>= 1.1),

I think it's better to include:

 libghc6-quickcheck2-dev (<< 2.2),
 libghc6-deepseq-dev (>= 1.1.0.0),
 libghc6-deepseq-dev (<< 1.1.0.1)

Also, it's better to include the -doc packages in Build-Depends-Indep, to avoid
the buildds from installing them.

Still about the example, I noticed two things:

A problem in the .cabal file:

example.cabal  Main.hs        Setup.hs       
marcot@zezinho:~/trabalho/livre/debian/pkg-haskell/haskell-tagsoup/example$ cp /usr/share/doc/libghc6-tagsoup-doc/examples/* .
marcot@zezinho:~/trabalho/livre/debian/pkg-haskell/haskell-tagsoup/example$ ghc --make Setup.hs 
[1 of 1] Compiling Main             ( Setup.hs, Setup.o )
Linking Setup ...
marcot@zezinho:~/trabalho/livre/debian/pkg-haskell/haskell-tagsoup/example$ ./Setup configure
Configuring tagsoup-0.4...
Setup: The field 'build-depends: tagsoup' refers to a library which is defined
within the same package. To use this feature the package must specify at least
'cabal-version: >= 1.8'.

I understand your point of including the .cabal file, but I think the .hs files
are enough: the user probably knows how to use ghc --make.

And a missing module:

marcot@zezinho:~/trabalho/livre/debian/pkg-haskell/haskell-tagsoup/example$ ghc --make Main

Main.hs:7:7:
    Could not find module `TagSoup.Benchmark':
      Use -v to see a list of the files searched for.

You may want to include the TagSoup directory in the .examples file.

Greetings.
(...)
-- 
marcot
http://wiki.debian.org/MarcoSilva

Attachment: signature.asc
Description: PGP signature


Reply to: