[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: r61963 - in trunk/src/debian-edu-config: debian sbin



Hi,

On Freitag, 22. Januar 2010, pere@alioth.debian.org wrote:
> Author: pere
> Date: 2010-01-22 11:49:16 +0000 (Fri, 22 Jan 2010)
> New Revision: 61963
>
> Modified:
>    trunk/src/debian-edu-config/debian/changelog
>    trunk/src/debian-edu-config/sbin/debian-edu-hwsetup
> Log:
> Implement recipe for installing the iwlagn wireless driver in
> Lenny in debian-edu-hwsetup.
>
> Modified: trunk/src/debian-edu-config/debian/changelog
> ===================================================================
> Modified: trunk/src/debian-edu-config/sbin/debian-edu-hwsetup
> ===================================================================
> --- trunk/src/debian-edu-config/sbin/debian-edu-hwsetup	2010-01-22 10:13:47
> UTC (rev 61962) +++
> trunk/src/debian-edu-config/sbin/debian-edu-hwsetup	2010-01-22 11:49:16 UTC
> (rev 61963) @@ -112,6 +112,40 @@
>  EOF
>  }
>
> +# Based on recipe from http://wiki.debian.org/iwlagn
> +install_wifi_iwlagn() {
> +    if lsmod | grep -q iwlagn ; then
> +	echo "info: Kernel module iwlagn already available, not upgrading kernel
> to make it available." +	return
> +    fi
> +    if [ -t 1 ] ; then
> +        # This recipe is interactive, only run when stdout is a tty
> +	append_if_missing /etc/apt/sources.list \
> +	    'deb http://www.backports.org/debian lenny-backports main contrib
> non-free' +	aptitude update
> +	aptitude -t lenny-backports install debian-backports-keyring
> +	aptitude update
> +	aptitude -t lenny-backports install linux-image-2.6.30-bpo.2-$(uname -r |
> sed 's,.*-,,g') firmware-iwlwifi wireless-tools +	echo
> "*******************************************************"

I think this is a way to far reaching change at this stage of the release 
process, even if it _should_ only run on specific machines. 

So I propose to revert this change (or move it into another branch. And then 
come back to it for squeeze or maybe the next lenny pointrelease). 

I wish I could write honestly that I'm open to be convinced but to be honest I 
cannot really imagine to be convinced otherwise. IMO the right solution is to 
document this and advise the admin to do this manually. There is a *lot* of 
current hardware which doesnt work with the lenny kernel, _automatically_ 
using 2.6.30 from bpo is no solution at this point in the release process 
IMO.


cheers,
	Holger

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: