[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Lintian ERROR saying dpatch is obsolete



Raphael Hertzog <hertzog@debian.org> writes:

> On Tue, 29 Nov 2011, Gergely Nagy wrote:
>> >  - Custom patch commands, as already discussed.  Yes, we should get rid of
>> >    them, but that doesn't make it easy to convert them.
>> 
>> echo skip-patches >>debian/source/options
>> 
>> And then in a pre-build target, do the scripting magic, and call dh $@
>> --with quilt or something similar, and in clean, do the reverse.
>> 
>> It needs minimal work, but it's - in my opinion - trivial
>> nevertheless. Less trivial than turning a 00list into series and living
>> happily ever after, but still trivial.
>
> Huh no, debian/source/options only affects the build of a source package,
> not its unpacking.

Ah, I see.

> And with custom patch commands, people do stuff different from applying
> patches in fact... some people mentionned moving or renaming files.

Yeah, what I was trying to accomplish is to make dpkg-source -x NOT
apply the quilt patches, so custom commands can be run before they're
applied.

Running stuff aterwards is trivial.

> IMO the proper fix in those cases is to integrate all this custom code
> directly in debian/rules.

Yeah, but at least in one case (hi, apache!) they're using a dpatch
script to do stuff BEFORE they apply patches (as the patches depend on
the results of this script). Converting that to quilt means that the
short dpatch script becomes a huge, useless patch that's pretty much
just noise.

I hoped that skip-patches would help here, but apparently not. That
makes this case a lot harder. :(

-- 
|8]


Reply to: