[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFC: Rules for distro-friendly packages

On Sun, Sep 19, 2010 at 02:07:10PM +0200, Josselin Mouette wrote:
> > The only "benefit" that AM_MAINTAINER_MODE can bring is cleaner deb diffs,
> > which can be obtained just as well by removing the modified generated files
> > in "debian/rules clean".
> > 
> > In fact, it would be nice to have a lintian check _against_ using that, and
> > forcing --disable-maintainer-mode to configure if it's present in the
> > upstream sources, since it being enabled means you're patching generated
> > files.
> You must be mistaken by automake’s counter-intuitiveness.
> The infamous maintainer mode *is the default* when you don’t set the
> macro. Setting AM_MAINTAINER_MODE actually disables maintainer mode
> unless you set --enable-maintainer-mode (which brings back the default
> behavior).

This is what I meant.

You need to either remove AM_MAINTAINER_MODE from configure.ac or
explicitely pass --enable-maintainer-mode or suffer the damage.

Having it disabled means that you either:
* don't build from source (a severity:important bug)
* ship sourceless code (a severity:serious bug)

A "configure" script produced by autotools is neither source, something
meant to be read by humans nor the preferred form of modification, so trying
to patch that is counterproductive -- either a waste of time and asking for
trouble if you did edit the real source, or a RC bug if you did not.

1KB		// Microsoft corollary to Hanlon's razor:
		//	Never attribute to stupidity what can be
		//	adequately explained by malice.

Reply to: