[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: /etc/shells management

On Mon, 8 Sep 2003 03:48:37 -0500, Branden Robinson <branden@debian.org> said: 

> I do continue to think that:

> if [ -n "$var" ]

> is more readable than

> if [ "${var+set}" = "set" ]

> ...but I remain open to being directed to a section of the Policy
> manual that firmly establishes my wrongness on that front as well.
> :)

	Now you are talking style issues.

	I still code reflextively from days when the only portable way
      if [ "X$var" != "X" ]; then foo; fi

 Readability lies in the eye of the beholder; for me this is idiomatic
 and eminently readable.  I confess that I rarely use the "${var+set}"
 idiom, I don't remember why I used it in favour of the "X$2" idiom

The finest eloquence is that which gets things done.
Manoj Srivastava   <srivasta@debian.org>  <http://www.debian.org/%7Esrivasta/>
1024R/C7261095 print CB D9 F4 12 68 07 E4 05  CC 2D 27 12 1D F5 E8 6E
1024D/BF24424C print 4966 F272 D093 B493 410B  924B 21BA DABB BF24 424C

Reply to: