[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: serious issues in piano booster 7.1 -- from the original author of the program.



Adding Oliver who has kindly helped with the french translations in the past.

Dear Miry,

We now know that "Ubuntu would need to pull the Debian package by 27 February. see. https://wiki.ubuntu.com/FocalFossa/ReleaseSchedule"

I have now completed all the code changes that I wanted to make for version 7.2 and it is nearly ready to go. I have greatly simplified the build options please see the updated recommend build options see https://github.com/captnfab/PianoBooster/blob/develop/pkgs/deb/debian.rules and also see the changes log  : https://github.com/captnfab/PianoBooster/blob/develop/Changelog.txt

The only thing left to sort out is the translations which are probably in the same stated as in 7.0 but I now recommend that the  INSTALL_ALL_LANGS=OFF which reduced number of included languages from 96 (More than even musecore  which only supports 66 languages) to a more manageable 18 languages.  Many of the 98 languages only have a few words/phrases translated.

> We could probably ping and ask for help in some of the Debian i18n mailing lists, and hopefully some people might want to help.
now would be a good time to suggest that. Also Oliver may want to help with french translations.

I don't know if there is anything you need to check in the develop branch before I do the 7.2 release.
> The current version available in the archive is 0.7.0 ( https://tracker.debian.org/pkg/pianobooster ), btw.
> That would mean this (duplicated) line, right?
Yes the code you showed me has that midi input key problem.

I hope we can fast track this release but I don't know if there is time to make it into the Ubuntu LTS.

Thanks

Louis


On Mon, Feb 3, 2020 at 10:09 PM Miriam Ruiz <miriam@debian.org> wrote:
El lun., 3 feb. 2020 a las 20:10, Louis B.
(<louisjbarman@googlemail.com>) escribió:
>
> Dear Miriam,
>
> Answers in line below but i wanted to highlight this question:
>
> I am worried that  piano booster 7.0 and 7.1 will make into the next Ubuntu LTS. Do you know what the time scales are now to get a fixed packaged into Ubuntu LTS??

AFAIK, "Ubuntu 20.04 LTS, which is due to be released on April 23,
2020" ( https://www.omgubuntu.co.uk/2019/10/ubuntu-20-04-release-features
). But I'm not really sure when the freezing of the packages is done.

> Here is the reported https://github.com/captnfab/PianoBooster/issues/207 bug.
> That is very strange have double checked this problem and even downloaded your source code from here.
> https://packages.debian.org/bullseye/pianobooster
>  And the offending line is MidiDevice.cpp line 136 which should be deleted as stops the following line from working as it swallows the the Midi inputs from the piano keyboard.
> I know that this is a silly question but you did test it playing along on the piano key board in follow mode. I think have  just worked out what may be happening have you turned down the sound on your keyboard or set your key board to MIDI local off so that you can here the right or wrong sounds controlled by piano booster

I will make sure that I check again with the latest version in the
archive to see if it works. The current version available in the
archive is 0.7.0 ( https://tracker.debian.org/pkg/pianobooster ), btw.

That would mean this (duplicated) line, right?

## 130 ## // Return the number of events waiting to be read from the midi device
## 131 ## int CMidiDevice::checkMidiInput()
## 132 ## {
## 133 ##    if (m_selectedMidiInputDevice == 0)
## 134 ##        return 0;
## 135 ##
## 136 ##    m_selectedMidiInputDevice->checkMidiInput();
<---------------------------
## 137 ##    return m_selectedMidiInputDevice->checkMidiInput();
## 138 ## }


> I am worried that  piano booster 7.0 and 7.1 will make into the next Ubuntu LTS. Do you know what the time scales are now to get a fixed packaged into Ubuntu LTS?? (Sorry I know I am should not really ask you that question).

It's a perfectly reasonable thing to ask and to worry about. Maybe
someone in the team knows better than me.

> I am currently reverting a few changes in 7.0 to reduce the number of build options and dependence. I would like to confirm these with your  Team before I do the release. I particularly want to make the use of Jack optional and not force the users to use jack which has a difficult learning curve for new users.

I agree with your point of view. I don't think there should be any
problems, as long as it works. Does anyone else see any?

I can certainly find a few hours in my agenda to work on it, most
likely during the weekend. Is the current code already in development?

Greetings,
Miry

Reply to: