May I indent the `dbootstrap' code?
I made some changes to `dbootstrap' earlier this week... I have
added two arguments to `execlog()' to make it optionally return the
output as a string as well as log it to syslog, and at many of the
call sites, have added that string as an error message to the dialog
box shown when the command fails.
I'd gotten part way through fixing up all of the call sites (I use
`global' and `gtags-mode' in XEmacs to find the call sites) of
`execlog()', and had been reformatting a lot of things along the way
because the indention, in my editor, was flat along the left edge;
there's a 4 space indent and a tab width of 4, which I'd assumed we
where using since that's what busybox is formatted like...
I would like to run indent, and set it to use the "linux" indention
style - With real tabs only, for indenting, rather than spaces and
tabs. It would look a lot better in there, some places, where
there's not been any whitespace placed between symbols, &c.
I've realized that I cannot check in the changes I've made to
`execlog()' unless the rest of the code is indented to match, or the
diff will likely be huge and the actual changes aside from formatting
will be hard to see... It will likely also cause merge conflicts in
other people's checkouts. (Then, so might the indent run, if we
don't co-ordinate carefully so that everyone is synced in prior to
running it and committing the result.)
Any objections? When can I do this?
Reply to: