[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Jim Studt: Re: Bug#60956: ARM is not supported (patch included)




------- Forwarded Message

Return-Path: root@burrito.onshore.com
Delivery-Date: Fri, 24 Mar 2000 14:29:57 -0500
Return-Path: <root@burrito.onshore.com>
Delivered-To: apharris@burrito.onshore.com
Received: by arroz.fake (Postfix, from userid 0)
	id 2C62893857; Fri, 24 Mar 2000 14:29:57 -0500 (EST)
Received: from core.federated.com (root@core.federated.com [199.217.175.51])
	by queso.onshore.com (8.9.3/8.9.3/Debian/GNU) with ESMTP id MAA25286
	for <adam@onshore.com>; Fri, 24 Mar 2000 12:30:02 -0600
Received: (from jim@localhost)
	by core.federated.com (8.9.3/8.9.3/Debian 8.9.3-6) id MAA21510
	for adam@onshore.com; Fri, 24 Mar 2000 12:29:59 -0600
From: Jim Studt <jim@federated.com>
Message-Id: <200003241829.MAA21510@core.federated.com>
Subject: Re: Bug#60956: ARM is not supported (patch included)
In-Reply-To: <oaya78g5ok.fsf@arroz.fake> from Adam Di Carlo at "Mar 24, 2000
 02:58:51 am"
To: Adam Di Carlo <adam@onshore.com>
Date: Fri, 24 Mar 2000 12:29:59 -0600 (CST)
X-Mailer: ELM [version 2.4ME+ PL66 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-UIDL: 04c4a8cc6eb5e5a7a44d60d7059200ef
Sender: root@burrito.onshore.com

>  - kernel.sh and install.sh: Why does ARM perversely use /boot/Image*
>    instead of /boot/vmlinuz* like anyone else?  Just different for the
>    sake of being different?  This seems to me like something that
>    ought to be fixed in the kernel-image-* packages, not changed in
>    boot-floppies.

I'll see what I can do here.  The Image file is a vmlinux that has been
mangled to sneak through a pseudo a.out loader that is in the firmware
of the netwinder.  Newer versions of the firmware can accept real vmlinux
files.  I may just add a release not that says "upgrade your firmware"
and abandon the Image.

>  - fdisk.c: this is a bugfix that I am not equipped to evaluate.
>    Can you explain why it is needed?

I'll try to determine if it is still needed.  You can see in the
fragment that if 'p' was already in the 'mounted_partitions' list
it would make a loop in the mounted-partitions linked list.  I 
think I BTSed that a while ago.  It may have been fixed where 'p'
is created by not reusing the already allocated structure.

> Index: fdisk.c
> ===================================================================
> RCS file: /cvs/debian-boot/boot-floppies/utilities/libfdisk/fdisk.c,v
> retrieving revision 1.44
> diff -u -u -r1.44 fdisk.c
> --- fdisk.c	2000/03/15 00:15:28	1.44
> +++ fdisk.c	2000/03/24 07:04:06
> @@ -725,11 +725,11 @@
>  #endif
>      p->in_use=-1;
>      p->mount_point=strdup(mnt_ent->mnt_dir);
> -    if (mounted_partitions) {
> +    if (mounted_partitions && p != mounted_partitions) {
>      /* reverse ordered, as this is the order in which they would be
>       * un-mounted. */
>          p->next_in_use=mounted_partitions;
> -    }
> +    } else p->next_in_use = 0;
>      mounted_partitions=p; 
>    }
>    endmntent(mtabFile);
> === Exit status: 1
> 


- -- 
                                     Jim Studt, President
                                     The Federated Software Group, Inc.



------- End of Forwarded Message


Reply to: