[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Testing CVS version of boot-floppies



On Dec 29, Chris Lawrence wrote:
> On Dec 29, Adam Di Carlo wrote:
> > Please retain CC to debian-boot mail list.
> > 
> > Luc Stepniewski <lstep@free.fr> writes:
> > > While installing the CVS version of boot-floppies (from 23 December), I
> > > noticed some problems:
> > > 
> > > 1) The new code to detect the CD drives works well, but: I have an
> > > IDE drive (/dev/hdd), and a SCSI drive (CD writer on /dev/sda).
> > > With the new code it detects well both drives, but selecting any of
> > > these (even the 'no drive correspond to my settings') returns to the
> > > beginning of the installation (welcome screen) ?!  If I make the
> > > installation (without turning on the SCSI drive), it works
> > > perfectly.
> > 
> > Chris, has this already been fixed?
> 
> Strange.  This is the first I've heard of such a problem.  I'll take a
> look-see this evening.

I located the problem; I did (n*sizeof(struct)+1) instead of
(n+1)*sizeof(struct).  Apparently two entries in the menu were OK, but
3+ triggered an overflow somewhere.  I *think*.  Please test; I've
checked in the change.

(a "make choose_medium_test" will let you test this specific menu
without building the whole shebang).


Chris
-- 
=============================================================================
|       Chris Lawrence       |   You have a computer.  Do you have Linux?   |
|  <quango@watervalley.net>  |     http://www.linux-m68k.org/index.html     |
|                            |                                              |
|      Debian Developer      |      Join the party that opposed the CDA     |
|   http://www.debian.org/   |              http://www.lp.org/              |
=============================================================================


Reply to: