Re: Blends pages, tasks pages etc.
Hi Ole,
On Wed, Dec 09, 2015 at 09:48:12AM +0100, Ole Streicher wrote:
> Andreas Tille <andreas@an3as.eu> writes:
> > UDD is developed here:
> > ssh://git.debian.org/git/collab-qa/udd.git
> > You need to define a new table and write an importer.
>
> As a first attempt, I would like here to add the total number of
> installations from popcon (IMO this is a missing number in the
> tasks.xhtml/packages.xhtml). I localized the place where the
> blends_query_packages SQL function is defined; the patch here would be
> simply (in udd.git)
I can confirm this simple patch. However, I intentionally left this
number out since I think it is pretty irrelevant to know how many people
in the world have once installed the package (may be simply as a
consequence of a metapackage dependency) but are not actually using it.
So my initial intention was to provide real *usage* number and not the
potentially higher number of (bit-roting) installations. Please do not
understand this as a veto against this number and I will not mind if
you put it on the pages - but I want you consider the potentially no
meaning of this number with a high "pure advertising potential".
> --- a/sql/setup.sql
> +++ b/sql/setup.sql
> @@ -1506,7 +1506,7
> enh.enhanced,
> rva.releases, versions, rva.architectures,
> upstream_version AS unstable_upstream, debian_mangled_uversion AS unstable_parsed_version, status AS unstable_status,
> - pop.vote, pop.recent,
> + pop.vote, pop.recent, pop.insts,
> tags.debtags,
> screenshot_versions, large_image_urls, small_image_urls,
> bibyear.value AS "year",
>
> This has to be accompanied in website.git with
>
> --- a/webtools/blendstasktools.py
> +++ b/webtools/blendstasktools.py
> @@ -317,7 +317,7 @@ query = """PREPARE query_pkgs (text[],text[]) AS
> enhanced text[],
> releases text[], versions text[], architectures text[],
> unstable_upstream text, unstable_parsed_version text, unstable_status text,
> - vote int, recent int, -- popcon
> + vote int, recent int, insts int, -- popcon
> debtags text[],
> screenshot_versions text[], image text[], icon text[],
> year text,
> @@ -1641,6 +1641,7 @@ class TaskDependencies:
>
> dep.popcon['vote'] = row['vote']
> dep.popcon['recent'] = row['recent']
> + dep.popcon['insts'] = row['insts']
>
> # Debtags as sorted list of dict fields
> if row['debtags']:
>
> Similarly ofcourse with the Python3 version.
>
> Question here: How to synchronize this? The number of arguments on both
> sides should match.
I need to say I have a bit bad gut feeling about doing the heave
development on code that is supposed to be replaced soon. We should
really coordinate with Akshita to finalise the Python3 code since I see
lots of duplicated work. From my perspective waiting for 1-2 monthes or
so does not harm at all. So even if I'm really happy that the tasks
pages coding became some dynamics it is probably not the best idea to
push that much in this very moment.
My personal schedule is to work hard on the Debian Med advent bug
squashing party[1] and concentrate on the Blends stuff afterwards.
To answer your question about synchronizing: I just pushed the UDD
change and the new Blends code on the same day. This was working nicely
for a single developer and I guess the triggering can be kept like this
since as far as I know I'm the only one with sudo permissions on
udd.debian.org.
Kind regards
Andreas.
[1] http://debian-med.alteholz.de/advent/
--
http://fam-tille.de
Reply to: