Hi,
On Wed, Jul 29, 2015 at 2:06 AM, Andreas Tille <
andreas@an3as.eu> wrote:
>
> Hi Akshita,
>
> I tried this with Debian Med but only had a quick look. I think it
> needs some cleaning of things like (very random example):
>
> @@ -5174,7 +4739,7 @@
> <data> : <end_tag> : table
> <data> : <end_tag> : span
> <data> : <start_tag> : div <attr> : ('class', 'popcon') <start_tag> : a <attr> : ('href', '
http://qa.debian.org/popcon-png.php?packages=fastqc&show_vote=on&show_recent=on&want_legend=on')
> - <data> : :
> <------> 7 users (2 upd.) <start_tag> : sup <start_tag> : a <attr> : ('href', '#popconexplanation') <data> : * <end_tag> : a
> + <data> : :
> <-----> 7 users (2 upd.) <start_tag> : sup <start_tag> : a <attr> : ('href', '#popconexplanation') <data> : * <end_tag> : a
> <end_tag> : sup
> <end_tag> : div
> <data> : <start_tag> : div <data> : <start_tag> : div <data> : <start_tag> : div <attr> : ('class', 'project-infomissing') <attr> : ('onmouseover', "TagToTip('fastqc-versions', FIX, ['fa
>
>
> I can not see a diff here - perhaps just whitespace? Such things should
> somehow vanish from the output.
This is solved now.
> While I follow your arguing that english definitely needs to be OK I
> think we should compare at least one additional language (preferably one
> featuring non-ASCII characters) as we have seen that these frequently
> cause problems. For me German sounds like a good candidate since it has
> such special characters and is quite good translated. May be having
> some command line argument specifying an additional language in addition
> to English would suffice.
>
As you suggested, I have made a slight change to allow an optional second command line argument to be given to the script. This argument has to be a lang in the form of 'de', 'da', 'fi' etc. This generates the diff of the tasks files in the specified language along with the diff in english (default).
Usage: ./test_output.py <Blend> <optional lang> eg: ./test_output.py debian-med de
> > The test_output.py for now is in webtools_py3 folder. Once you confirm that
> > the diff output is as desired, I'll move it to tests folder. FWIW, the
> > difference in the tasks files is mainly because of the order (by order I
> > mean that the order of packages within a section may differ but the
> > packages in each section remain the same).
>
> How do you explain this order difference. The old tasks.py creates
> alphabethic ordering. This should be easily possible also in the
> rewrite. Or am I missing something.
By change in order, I did not mean the name of packages (which are in alphabetical order) but something like the below (from bio.en.html.diff) :
<start_tag> : th <attr> : ('class', 'version') <data> : Version <end_tag> : th
<start_tag> : th <attr> : ('class', 'archs') <data> : Architectures <end_tag> : th
<end_tag> : tr
+<data> : <start_tag> : tr <start_tag> : td <attr> : ('class', 'release') <data> : stretch <end_tag> : td
+<start_tag> : td <attr> : ('class', 'version') <data> : 1.3.1-2 <end_tag> : td
+<start_tag> : td <attr> : ('class', 'archs') <data> : all <end_tag> : td
+<end_tag> : tr
+<data> : <start_tag> : tr <start_tag> : td <attr> : ('class', 'release') <data> : wheezy <end_tag> : td
+<start_tag> : td <attr> : ('class', 'version') <data> : 1.3.1-1 <end_tag> : td
+<start_tag> : td <attr> : ('class', 'archs') <data> : all <end_tag> : td
+<end_tag> : tr
+<data> : <start_tag> : tr <start_tag> : td <attr> : ('class', 'release') <data> : sid <end_tag> : td
+<start_tag> : td <attr> : ('class', 'version') <data> : 1.3.1-2 <end_tag> : td
+<start_tag> : td <attr> : ('class', 'archs') <data> : all <end_tag> : td
+<end_tag> : tr
<data> : <start_tag> : tr <start_tag> : td <attr> : ('class', 'release') <data> : jessie <end_tag> : td
<start_tag> : td <attr> : ('class', 'version') <data> : 1.3.1-2 <end_tag> : td
<start_tag> : td <attr> : ('class', 'archs') <data> : all <end_tag> : td
<end_tag> : tr
-<data> : <start_tag> : tr <start_tag> : td <attr> : ('class', 'release') <data> : sid <end_tag> : td
-<start_tag> : td <attr> : ('class', 'version') <data> : 1.3.1-2 <end_tag> : td
-<start_tag> : td <attr> : ('class', 'archs') <data> : all <end_tag> : td
-<end_tag> : tr
-<data> : <start_tag> : tr <start_tag> : td <attr> : ('class', 'release') <data> : stretch <end_tag> : td
-<start_tag> : td <attr> : ('class', 'version') <data> : 1.3.1-2 <end_tag> : td
-<start_tag> : td <attr> : ('class', 'archs') <data> : all <end_tag> : td
-<end_tag> : tr
-<data> : <start_tag> : tr <start_tag> : td <attr> : ('class', 'release') <data> : wheezy <end_tag> : td
-<start_tag> : td <attr> : ('class', 'version') <data> : 1.3.1-1 <end_tag> : td
-<start_tag> : td <attr> : ('class', 'archs') <data> : all <end_tag> : td
-<end_tag> : tr
The diff is due to the difference in order: tasks.html : (sid, stretch, wheezy) and tasks_udd.html (stretch, wheezy, sid). Should this also be in alphabetical order ?
> So far for my first notes.
Please have a look at the above changes and kindly suggest what else can be improved/changed ?
--
Regards,
Akshita Jha