Re: [GsoC] your latest commit of tasks_udd.py
Hi Akshita,
On Wed, Jul 29, 2015 at 12:17:38AM +0530, Akshita Jha wrote:
>
> I have written a script: test_output.py which parses the old and the new
> tasks files and gives the difference between the two. The script
> test_ouput.py makes use of HTMLParser library[0] and difflib[1] standard
> libraries of Python 3.
>
> To run the script : ./test_output.py <Blend> eg: ./test_output.py debian-med
> Ouputdir : ./tests/<Blend>/<task_file.diff>
I tried this with Debian Med but only had a quick look. I think it
needs some cleaning of things like (very random example):
@@ -5174,7 +4739,7 @@
<data> : <end_tag> : table
<data> : <end_tag> : span
<data> : <start_tag> : div <attr> : ('class', 'popcon') <start_tag> : a <attr> : ('href', 'http://qa.debian.org/popcon-png.php?packages=fastqc&show_vote=on&show_recent=on&want_legend=on')
- <data> : :
<------> 7 users (2 upd.) <start_tag> : sup <start_tag> : a <attr> : ('href', '#popconexplanation') <data> : * <end_tag> : a
+ <data> : :
<-----> 7 users (2 upd.) <start_tag> : sup <start_tag> : a <attr> : ('href', '#popconexplanation') <data> : * <end_tag> : a
<end_tag> : sup
<end_tag> : div
<data> : <start_tag> : div <data> : <start_tag> : div <data> : <start_tag> : div <attr> : ('class', 'project-infomissing') <attr> : ('onmouseover', "TagToTip('fastqc-versions', FIX, ['fa
I can not see a diff here - perhaps just whitespace? Such things should
somehow vanish from the output.
> For now, I am just computing the difference between the english versions of
> task files. I feel it'll be faster this way and I am assuming the
> translations will have the same differences. This is not an issue and is
> easy to change.
While I follow your arguing that english definitely needs to be OK I
think we should compare at least one additional language (preferably one
featuring non-ASCII characters) as we have seen that these frequently
cause problems. For me German sounds like a good candidate since it has
such special characters and is quite good translated. May be having
some command line argument specifying an additional language in addition
to English would suffice.
> The test_output.py for now is in webtools_py3 folder. Once you confirm that
> the diff output is as desired, I'll move it to tests folder. FWIW, the
> difference in the tasks files is mainly because of the order (by order I
> mean that the order of packages within a section may differ but the
> packages in each section remain the same).
How do you explain this order difference. The old tasks.py creates
alphabethic ordering. This should be easily possible also in the
rewrite. Or am I missing something.
> Needless to say, the script may require lots of changes. Can you please go
> through the output and let me know.
So far for my first notes.
Kind regards
Andreas.
--
http://fam-tille.de
Reply to: