Re: Cloudy package ready for review

[Ole Streicher <olebole@debian.org>]

Hi Roger,

Roger Wesson <rw@nebulousresearch.org> writes:
> I've simplified the install files.  As for the package not compiling, I
> forgot to mention before that I could not reproduce that. I built the
> package successfully on my own machine and on launchpad.

The problem here seems to be that you use Ubuntu 14.04 (trusty) for
both, which is quite old. If you try it on 16.04 (xenial) or the
upcoming 17.10 (yaakkety), you will observer the same failures:

* xenial: https://launchpad.net/~olebole/+archive/ubuntu/astro-xenial/+build/9900284/+files/buildlog_ubuntu-xenial-amd64.cloudy_13.03-0.utest1_BUILDING.txt.gz 
* yakkety https://launchpad.net/~olebole/+archive/ubuntu/astro-yakkety/+build/9900444/+files/buildlog_ubuntu-yakkety-amd64.cloudy_13.03-0.utest1_BUILDING.txt.gz

Generally, it must be built under the latest Debian unstable/testing. To
ensure this, I would strongly recommend to install "pbuilder". This
allows to build the package in a clean, actual Debian unstable
environment independently of what Distribution you actually use.

> Looking at the log of the failed build, it seems that pbuilder did not
> try to resolve the dependencies and did not install libc etc for the
> build, which therefore failed.

The libc (and the C compiler) are already installed by default. There is
no need to select them manually.

The first error in the log file is

g++ -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -ansi -O3 -
In file included from /usr/include/c++/5/valarray:90:0,
                 from cddefines.h:59,
                 from maincl.cpp:6:
/usr/include/c++/5/bits/valarray_before.h: In instantiation of 'struct std::__fu
/usr/include/c++/5/valarray:121:50:   required from 'struct std::valarray<molezo
/usr/include/c++/5/valarray:1073:96:   required from 'class std::valarray<molezo
mole.h:355:27:   required from here
/usr/include/c++/5/bits/valarray_before.h:350:12: error: invalid use of incomple
     struct __fun : __fun_with_valarray<_Tp>
            ^
which for me looks like some forward declaration, which older C++
compilers may have allowed but the current one doesn't (no real idea; I
am not a C++ expert). You could try to find out yourself how to fix that
(and submit to upstream), or discuss it with upstream whether he has a fix.

Best regards

Ole