Re: Cloudy package ready for review
Hi Roger,
thank you for your packaging. This package will be a great contribution
to Debian Astro! I have a few remarks:
- in debian/changelog, change the distribution name from "trusty" to
"unstable". Also update the date in debian/changelog.
- Please specify the license of the data. While many data files are
(probably?) covered by the main license, the Chianti database files
are copied from Chianti. In the README_CHIANTI file it is just stated
that the data are "distributed freely", but no license is specified. I
could imagine that it is the same (ISC) license as ChiantiPy
https://github.com/chianti-atomic/ChiantiPy/blob/master/LICENSE
but please ask the Chianti people for an advise (recommend to use the
ISC license as for ChiantiPy).
You should also add the origins of all other data files (see the
READMEs in the different subdirs of data/)
- The first license is "Zlib", not "custom", please adjust the short
name. This makes it easier for the ftp-masters to approve that it is
free according to the DFSG.
- You should also investigate the licenses of the file
"source/thirdparty.cpp". The file states in the header "Use and
distribution of these works are determined by their respective
copyrights." Please ask upstream about these copyrights and licenses,
and/or try to find their origins yourself.
- Please consider not using GPL for the Debian files. This makes the
whole package as GPL, which may give problems if one links it to
incompatible versions (f.e. repackaging with non-free data). Also, if
someone wants to take something out of your debian files into his own
packaging, he has to use GPL for his own files. For simplicity, I
would recommend the same license as the main files (Zlib). This is
however just a hint -- you are perfectly allowed to choose GPL, and I
will sponsor it also when you decide to keep it as it is.
- The build in a clean "unstable" environment fails; the build log is
attached.
- The manpage is a bit short. It should include at least the help
output. BTW, there is a package in Debian, "help2man" which can
convert help output (as long as it is somehow standard) into a
manpage. That may be used as a start.
- please include a debian/watch file
- Please split the package into the program itself, the documentation,
and the data. The documentation and the data are quite large, and the
package is architecture dependent. That means that the package will
be built for all architectures available in Debian (which are
currently 10 official and 12 non-official), and each binary then
would include all ~60 MB data and documentation. This is quite a
waste of space. If you build architecture-independent data files
(with "Architecture: all"), the data files and documentation are
stored only once. People then may also have the option to remove the
documentation if they don't need it.
Best regards
Ole
On 07.06.2016 00:41, Roger Wesson wrote:
> Hi,
>
> I've just uploaded the files for a package of cloudy, a widely used
> astronomical simulation code which had had an RFP since 2013. It's
> ready for review. First time I packaged someone else's software so I
> hope I haven't made too many mistakes.
>
> http://anonscm.debian.org/cgit/debian-astro/packages/cloudy.git/
>
> Thanks!
> Roger
>
dpkg-buildpackage: info: source package cloudy
dpkg-buildpackage: info: source version 13.03-1
dpkg-buildpackage: info: source distribution trusty
dpkg-buildpackage: info: source changed by Roger Wesson <rw@nebulousresearch.org>
dpkg-source --before-build cloudy
fakeroot debian/rules clean
dh clean
dh_testdir
dh_auto_clean
make -j1 clean
make[1]: Entering directory '/home/oles/Projects/2011/debian/sponsoring/cloudy'
cd source && make clean
make[2]: Entering directory '/home/oles/Projects/2011/debian/sponsoring/cloudy/source'
rm -f *.o
rm -f *.d
rm -f *.h.gch
rm -rf SunWS_cache
rm -rf cloudy.dSYM
rm -f libcloudy.a
rm -f cloudy data
rm -f runtests
rm -rf tmp_cloudyconfig.*
make[2]: Leaving directory '/home/oles/Projects/2011/debian/sponsoring/cloudy/source'
make[1]: Leaving directory '/home/oles/Projects/2011/debian/sponsoring/cloudy'
dh_clean
dpkg-source -b cloudy
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: info: building cloudy using existing ./cloudy_13.03.orig.tar.gz
dpkg-source: warning: ignoring deletion of directory data/stout/n
dpkg-source: info: building cloudy in cloudy_13.03-1.debian.tar.xz
dpkg-source: info: building cloudy in cloudy_13.03-1.dsc
dpkg-genchanges --build=source >../cloudy_13.03-1_source.changes
dpkg-genchanges: info: including full source code in upload
dpkg-source --after-build cloudy
dpkg-source: info: unapplying man.patch
dpkg-source: info: unapplying Makefile2.patch
dpkg-source: info: unapplying path.h.patch
dpkg-source: info: unapplying Makefile.patch
dpkg-buildpackage: info: full upload (original source is included)
-> Copying COW directory
forking: rm -rf /var/cache/pbuilder/build/cow.14293
forking: cp -al /var/cache/pbuilder/base.cow /var/cache/pbuilder/build/cow.14293
I: removed stale ilistfile /var/cache/pbuilder/build/cow.14293/.ilist
forking: chroot /var/cache/pbuilder/build/cow.14293 cowdancer-ilistcreate /.ilist find . -xdev -path ./home -prune -o \( \( -type l -o -type f \) -a -links +1 -print0 \) | xargs -0 stat --format '%d %i '
-> Invoking pbuilder
forking: pbuilder build --debbuildopts --debbuildopts --buildplace /var/cache/pbuilder/build/cow.14293 --buildresult /var/cache/pbuilder/result/ --no-targz --internal-chrootexec chroot /var/cache/pbuilder/build/cow.14293 cow-shell /home/oles/Projects/2011/debian/sponsoring/cloudy_13.03-1.dsc
I: Running in no-targz mode
I: using fakeroot in build.
I: pbuilder: network access will be disabled during build
I: Current time: Tue Jun 7 09:47:17 CEST 2016
I: pbuilder-time-stamp: 1465285637
I: copying local configuration
W: hookdir /var/cache/pbuilder/hooks does not exist, skipping
I: mounting /proc filesystem
I: mounting /run/shm filesystem
I: mounting /dev/pts filesystem
I: Mounting /var/cache/pbuilder/ccache
I: policy-rc.d already exists
W: no hooks of type H found -- ignoring
I: Obtaining the cached apt archive contents
I: Installing the build-deps
W: no hooks of type D found -- ignoring
Reading package lists...
Building dependency tree...
Reading state information...
Suggested packages:
autoconf-archive gnu-standards autoconf-doc wamerican | wordlist whois
vacation dh-make gettext-doc libasprintf-dev libgettextpo-dev groff
libtool-doc gfortran | fortran95-compiler gcj-jdk less www-browser
libmail-box-perl
Recommended packages:
curl | wget | lynx-cur libglib2.0-data shared-mime-info xdg-user-dirs
libltdl-dev xml-core libmail-sendmail-perl
The following NEW packages will be installed:
autoconf automake autopoint autotools-dev bsdmainutils debhelper
dh-autoreconf dh-strip-nondeterminism file gettext gettext-base groff-base
intltool-debian libarchive-zip-perl libbsd0 libcroco3 libffi6
libfile-stripnondeterminism-perl libglib2.0-0 libicu55 libmagic1
libpipeline1 libsigsegv2 libtool libunistring0 libxml2 m4 man-db po-debconf
debconf: delaying package configuration, since apt-utils is not installed
0 upgraded, 29 newly installed, 0 to remove and 0 not upgraded.
Need to get 0 B/19.4 MB of archives.
After this operation, 66.0 MB of additional disk space will be used.
Selecting previously unselected package groff-base.
(Reading database ...
(Reading database ... 5%
(Reading database ... 10%
(Reading database ... 15%
(Reading database ... 20%
(Reading database ... 25%
(Reading database ... 30%
(Reading database ... 35%
(Reading database ... 40%
(Reading database ... 45%
(Reading database ... 50%
(Reading database ... 55%
(Reading database ... 60%
(Reading database ... 65%
(Reading database ... 70%
(Reading database ... 75%
(Reading database ... 80%
(Reading database ... 85%
(Reading database ... 90%
(Reading database ... 95%
(Reading database ... 100%
(Reading database ... 13756 files and directories currently installed.)
Preparing to unpack .../groff-base_1.22.3-7_amd64.deb ...
Unpacking groff-base (1.22.3-7) ...
Selecting previously unselected package libbsd0:amd64.
Preparing to unpack .../libbsd0_0.8.3-1_amd64.deb ...
Unpacking libbsd0:amd64 (0.8.3-1) ...
Selecting previously unselected package bsdmainutils.
Preparing to unpack .../bsdmainutils_9.0.10_amd64.deb ...
Unpacking bsdmainutils (9.0.10) ...
Selecting previously unselected package libpipeline1:amd64.
Preparing to unpack .../libpipeline1_1.4.1-2_amd64.deb ...
Unpacking libpipeline1:amd64 (1.4.1-2) ...
Selecting previously unselected package man-db.
Preparing to unpack .../man-db_2.7.5-1_amd64.deb ...
Unpacking man-db (2.7.5-1) ...
Selecting previously unselected package libmagic1:amd64.
Preparing to unpack .../libmagic1_1%3a5.25-2_amd64.deb ...
Unpacking libmagic1:amd64 (1:5.25-2) ...
Selecting previously unselected package file.
Preparing to unpack .../file_1%3a5.25-2_amd64.deb ...
Unpacking file (1:5.25-2) ...
Selecting previously unselected package gettext-base.
Preparing to unpack .../gettext-base_0.19.7-2_amd64.deb ...
Unpacking gettext-base (0.19.7-2) ...
Selecting previously unselected package libicu55:amd64.
Preparing to unpack .../libicu55_55.1-7_amd64.deb ...
Unpacking libicu55:amd64 (55.1-7) ...
Selecting previously unselected package libxml2:amd64.
Preparing to unpack .../libxml2_2.9.3+dfsg1-1.2_amd64.deb ...
Unpacking libxml2:amd64 (2.9.3+dfsg1-1.2) ...
Selecting previously unselected package libsigsegv2:amd64.
Preparing to unpack .../libsigsegv2_2.10-5_amd64.deb ...
Unpacking libsigsegv2:amd64 (2.10-5) ...
Selecting previously unselected package m4.
Preparing to unpack .../archives/m4_1.4.17-5_amd64.deb ...
Unpacking m4 (1.4.17-5) ...
Selecting previously unselected package autoconf.
Preparing to unpack .../autoconf_2.69-10_all.deb ...
Unpacking autoconf (2.69-10) ...
Selecting previously unselected package autotools-dev.
Preparing to unpack .../autotools-dev_20160430.1_all.deb ...
Unpacking autotools-dev (20160430.1) ...
Selecting previously unselected package automake.
Preparing to unpack .../automake_1%3a1.15-4_all.deb ...
Unpacking automake (1:1.15-4) ...
Selecting previously unselected package autopoint.
Preparing to unpack .../autopoint_0.19.7-2_all.deb ...
Unpacking autopoint (0.19.7-2) ...
Selecting previously unselected package libffi6:amd64.
Preparing to unpack .../libffi6_3.2.1-4_amd64.deb ...
Unpacking libffi6:amd64 (3.2.1-4) ...
Selecting previously unselected package libglib2.0-0:amd64.
Preparing to unpack .../libglib2.0-0_2.48.1-1_amd64.deb ...
Unpacking libglib2.0-0:amd64 (2.48.1-1) ...
Selecting previously unselected package libcroco3:amd64.
Preparing to unpack .../libcroco3_0.6.11-1_amd64.deb ...
Unpacking libcroco3:amd64 (0.6.11-1) ...
Selecting previously unselected package libunistring0:amd64.
Preparing to unpack .../libunistring0_0.9.6+really0.9.3-0.1_amd64.deb ...
Unpacking libunistring0:amd64 (0.9.6+really0.9.3-0.1) ...
Selecting previously unselected package gettext.
Preparing to unpack .../gettext_0.19.7-2_amd64.deb ...
Unpacking gettext (0.19.7-2) ...
Selecting previously unselected package intltool-debian.
Preparing to unpack .../intltool-debian_0.35.0+20060710.4_all.deb ...
Unpacking intltool-debian (0.35.0+20060710.4) ...
Selecting previously unselected package po-debconf.
Preparing to unpack .../po-debconf_1.0.19_all.deb ...
Unpacking po-debconf (1.0.19) ...
Selecting previously unselected package libarchive-zip-perl.
Preparing to unpack .../libarchive-zip-perl_1.57-1_all.deb ...
Unpacking libarchive-zip-perl (1.57-1) ...
Selecting previously unselected package libfile-stripnondeterminism-perl.
Preparing to unpack .../libfile-stripnondeterminism-perl_0.018-1_all.deb ...
Unpacking libfile-stripnondeterminism-perl (0.018-1) ...
Selecting previously unselected package dh-strip-nondeterminism.
Preparing to unpack .../dh-strip-nondeterminism_0.018-1_all.deb ...
Unpacking dh-strip-nondeterminism (0.018-1) ...
Selecting previously unselected package libtool.
Preparing to unpack .../libtool_2.4.6-0.1_all.deb ...
Unpacking libtool (2.4.6-0.1) ...
Selecting previously unselected package dh-autoreconf.
Preparing to unpack .../dh-autoreconf_12_all.deb ...
Unpacking dh-autoreconf (12) ...
Selecting previously unselected package debhelper.
Preparing to unpack .../debhelper_9.20160403_all.deb ...
Unpacking debhelper (9.20160403) ...
Processing triggers for libc-bin (2.22-11) ...
Setting up groff-base (1.22.3-7) ...
Setting up libbsd0:amd64 (0.8.3-1) ...
Setting up bsdmainutils (9.0.10) ...
update-alternatives: using /usr/bin/bsd-write to provide /usr/bin/write (write) in auto mode
update-alternatives: using /usr/bin/bsd-from to provide /usr/bin/from (from) in auto mode
Setting up libpipeline1:amd64 (1.4.1-2) ...
Setting up man-db (2.7.5-1) ...
Building database of manual pages ...
Setting up libmagic1:amd64 (1:5.25-2) ...
Setting up file (1:5.25-2) ...
Setting up gettext-base (0.19.7-2) ...
Setting up libicu55:amd64 (55.1-7) ...
Setting up libxml2:amd64 (2.9.3+dfsg1-1.2) ...
Setting up libsigsegv2:amd64 (2.10-5) ...
Setting up m4 (1.4.17-5) ...
Setting up autoconf (2.69-10) ...
Setting up autotools-dev (20160430.1) ...
Setting up automake (1:1.15-4) ...
update-alternatives: using /usr/bin/automake-1.15 to provide /usr/bin/automake (automake) in auto mode
Setting up autopoint (0.19.7-2) ...
Setting up libffi6:amd64 (3.2.1-4) ...
Setting up libglib2.0-0:amd64 (2.48.1-1) ...
No schema files found: doing nothing.
Setting up libcroco3:amd64 (0.6.11-1) ...
Setting up libunistring0:amd64 (0.9.6+really0.9.3-0.1) ...
Setting up gettext (0.19.7-2) ...
Setting up intltool-debian (0.35.0+20060710.4) ...
Setting up po-debconf (1.0.19) ...
Setting up libarchive-zip-perl (1.57-1) ...
Setting up libfile-stripnondeterminism-perl (0.018-1) ...
Setting up libtool (2.4.6-0.1) ...
Setting up dh-strip-nondeterminism (0.018-1) ...
Setting up debhelper (9.20160403) ...
Setting up dh-autoreconf (12) ...
Processing triggers for libc-bin (2.22-11) ...
Reading package lists...
Building dependency tree...
Reading state information...
The following additional packages will be installed:
libfakeroot
The following NEW packages will be installed:
fakeroot libfakeroot
debconf: delaying package configuration, since apt-utils is not installed
0 upgraded, 2 newly installed, 0 to remove and 0 not upgraded.
Need to get 0 B/130 kB of archives.
After this operation, 368 kB of additional disk space will be used.
Selecting previously unselected package libfakeroot:amd64.
(Reading database ...
(Reading database ... 5%
(Reading database ... 10%
(Reading database ... 15%
(Reading database ... 20%
(Reading database ... 25%
(Reading database ... 30%
(Reading database ... 35%
(Reading database ... 40%
(Reading database ... 45%
(Reading database ... 50%
(Reading database ... 55%
(Reading database ... 60%
(Reading database ... 65%
(Reading database ... 70%
(Reading database ... 75%
(Reading database ... 80%
(Reading database ... 85%
(Reading database ... 90%
(Reading database ... 95%
(Reading database ... 100%
(Reading database ... 15612 files and directories currently installed.)
Preparing to unpack .../libfakeroot_1.20.2-2_amd64.deb ...
Unpacking libfakeroot:amd64 (1.20.2-2) ...
Selecting previously unselected package fakeroot.
Preparing to unpack .../fakeroot_1.20.2-2_amd64.deb ...
Unpacking fakeroot (1.20.2-2) ...
Processing triggers for libc-bin (2.22-11) ...
Processing triggers for man-db (2.7.5-1) ...
Setting up libfakeroot:amd64 (1.20.2-2) ...
Setting up fakeroot (1.20.2-2) ...
update-alternatives: using /usr/bin/fakeroot-sysv to provide /usr/bin/fakeroot (fakeroot) in auto mode
Processing triggers for libc-bin (2.22-11) ...
I: Copying back the cached apt archive contents
I: Copying source file
I: copying [/home/oles/Projects/2011/debian/sponsoring/cloudy_13.03-1.dsc]
I: copying [/home/oles/Projects/2011/debian/sponsoring/cloudy_13.03.orig.tar.gz]
I: copying [/home/oles/Projects/2011/debian/sponsoring/cloudy_13.03-1.debian.tar.xz]
I: Extracting source
dpkg-source: warning: extracting unsigned source package (cloudy_13.03-1.dsc)
dpkg-source: info: extracting cloudy in cloudy-13.03
dpkg-source: info: unpacking cloudy_13.03.orig.tar.gz
dpkg-source: info: unpacking cloudy_13.03-1.debian.tar.xz
dpkg-source: info: applying Makefile.patch
dpkg-source: info: applying path.h.patch
dpkg-source: info: applying Makefile2.patch
dpkg-source: info: applying man.patch
I: Building the package
W: no hooks of type A found -- ignoring
I: Running cd /build/*/ && env PATH="/usr/lib/ccache:/usr/sbin:/usr/bin:/sbin:/bin" HOME="/nonexistent" dpkg-buildpackage -us -uc -rfakeroot
dpkg-buildpackage: info: source package cloudy
dpkg-buildpackage: info: source version 13.03-1
dpkg-buildpackage: info: source distribution trusty
dpkg-buildpackage: info: source changed by Roger Wesson <rw@nebulousresearch.org>
dpkg-source --before-build cloudy-13.03
dpkg-buildpackage: info: host architecture amd64
fakeroot debian/rules clean
dh clean
dh_testdir
dh_auto_clean
make -j1 clean
make[1]: Entering directory '/build/cloudy-13.03'
cd source && make clean
make[2]: Entering directory '/build/cloudy-13.03/source'
rm -f *.o
rm -f *.d
rm -f *.h.gch
rm -rf SunWS_cache
rm -rf cloudy.dSYM
rm -f libcloudy.a
rm -f cloudy data
rm -f runtests
rm -rf tmp_cloudyconfig.*
make[2]: Leaving directory '/build/cloudy-13.03/source'
make[1]: Leaving directory '/build/cloudy-13.03'
dh_clean
dpkg-source -b cloudy-13.03
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: info: building cloudy using existing ./cloudy_13.03.orig.tar.gz
dpkg-source: info: building cloudy in cloudy_13.03-1.debian.tar.xz
dpkg-source: info: building cloudy in cloudy_13.03-1.dsc
debian/rules build
dh build
dh_testdir
dh_update_autotools_config
dh_auto_configure
dh_auto_build
make -j1
make[1]: Entering directory '/build/cloudy-13.03'
rm data/cdms+jpl/.gitignore
rm data/chianti/mn/mn_8/.meo.swp
cd source/ && make
make[2]: Entering directory '/build/cloudy-13.03/source'
Creating cloudyconfig.h
g++ -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -ansi -O3 -ftrapping-math -fno-math-errno -ftree-vectorize -Wall -W -g -DSVN_REVISION=\"exported\" -DSYS_CONFIG=\"/build/cloudy-13.03/source/cloudyconfig.h\" -o cddefines.h.gch cddefines.h
./make_depend.pl "g++ -MM -MG -DMM -DSVN_REVISION=\"exported\" -DSYS_CONFIG=\"/build/cloudy-13.03/source/cloudyconfig.h\" cddefines.h" cddefines.o cddefines.h.gch /build/cloudy-13.03/source/cloudyconfig.h cddefines.h.d
g++ -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -ansi -O3 -ftrapping-math -fno-math-errno -ftree-vectorize -Wall -W -g -DSVN_REVISION=\"exported\" -DSYS_CONFIG=\"/build/cloudy-13.03/source/cloudyconfig.h\" -c -o maincl.o maincl.cpp
In file included from /usr/include/c++/5/valarray:90:0,
from cddefines.h:59:
/usr/include/c++/5/bits/valarray_before.h: In instantiation of 'struct std::__fun<std::__unary_plus, molezone>':
/usr/include/c++/5/valarray:121:50: required from 'struct std::valarray<molezone>::_UnaryOp<std::__unary_plus>'
/usr/include/c++/5/valarray:1073:5: required from 'class std::valarray<molezone>'
mole.h:355:27: required from here
/usr/include/c++/5/bits/valarray_before.h:350:12: error: invalid use of incomplete type 'class molezone'
struct __fun : __fun_with_valarray<_Tp>
^
In file included from h2_priv.h:9:0,
from save.h:8,
from maincl.cpp:10:
mole.h:355:17: note: forward declaration of 'class molezone'
valarray<class molezone> species;
^
In file included from cddefines.h:59:0:
/usr/include/c++/5/valarray: In instantiation of 'struct std::valarray<molezone>::_UnaryOp<std::__unary_plus>':
/usr/include/c++/5/valarray:1073:5: required from 'class std::valarray<molezone>'
mole.h:355:27: required from here
/usr/include/c++/5/valarray:121:50: error: no type named 'result_type' in 'struct std::__fun<std::__unary_plus, molezone>'
typedef typename __fun<_Op, _Tp>::result_type __rt;
^
/usr/include/c++/5/valarray:122:54: error: no type named 'result_type' in 'struct std::__fun<std::__unary_plus, molezone>'
typedef _Expr<_UnClos<_Op, _ValArray, _Tp>, __rt> _Rt;
^
In file included from /usr/include/c++/5/valarray:90:0,
from cddefines.h:59:
/usr/include/c++/5/bits/valarray_before.h: In instantiation of 'struct std::__fun<std::__negate, molezone>':
/usr/include/c++/5/valarray:121:50: required from 'struct std::valarray<molezone>::_UnaryOp<std::__negate>'
/usr/include/c++/5/valarray:1074:5: required from 'class std::valarray<molezone>'
mole.h:355:27: required from here
/usr/include/c++/5/bits/valarray_before.h:350:12: error: invalid use of incomplete type 'class molezone'
struct __fun : __fun_with_valarray<_Tp>
^
In file included from h2_priv.h:9:0,
from save.h:8,
from maincl.cpp:10:
mole.h:355:17: note: forward declaration of 'class molezone'
valarray<class molezone> species;
^
In file included from cddefines.h:59:0:
/usr/include/c++/5/valarray: In instantiation of 'struct std::valarray<molezone>::_UnaryOp<std::__negate>':
/usr/include/c++/5/valarray:1074:5: required from 'class std::valarray<molezone>'
mole.h:355:27: required from here
/usr/include/c++/5/valarray:121:50: error: no type named 'result_type' in 'struct std::__fun<std::__negate, molezone>'
typedef typename __fun<_Op, _Tp>::result_type __rt;
^
/usr/include/c++/5/valarray:122:54: error: no type named 'result_type' in 'struct std::__fun<std::__negate, molezone>'
typedef _Expr<_UnClos<_Op, _ValArray, _Tp>, __rt> _Rt;
^
In file included from /usr/include/c++/5/valarray:90:0,
from cddefines.h:59:
/usr/include/c++/5/bits/valarray_before.h: In instantiation of 'struct std::__fun<std::__bitwise_not, molezone>':
/usr/include/c++/5/valarray:121:50: required from 'struct std::valarray<molezone>::_UnaryOp<std::__bitwise_not>'
/usr/include/c++/5/valarray:1075:5: required from 'class std::valarray<molezone>'
mole.h:355:27: required from here
/usr/include/c++/5/bits/valarray_before.h:350:12: error: invalid use of incomplete type 'class molezone'
struct __fun : __fun_with_valarray<_Tp>
^
In file included from h2_priv.h:9:0,
from save.h:8,
from maincl.cpp:10:
mole.h:355:17: note: forward declaration of 'class molezone'
valarray<class molezone> species;
^
In file included from cddefines.h:59:0:
/usr/include/c++/5/valarray: In instantiation of 'struct std::valarray<molezone>::_UnaryOp<std::__bitwise_not>':
/usr/include/c++/5/valarray:1075:5: required from 'class std::valarray<molezone>'
mole.h:355:27: required from here
/usr/include/c++/5/valarray:121:50: error: no type named 'result_type' in 'struct std::__fun<std::__bitwise_not, molezone>'
typedef typename __fun<_Op, _Tp>::result_type __rt;
^
/usr/include/c++/5/valarray:122:54: error: no type named 'result_type' in 'struct std::__fun<std::__bitwise_not, molezone>'
typedef _Expr<_UnClos<_Op, _ValArray, _Tp>, __rt> _Rt;
^
In file included from cddefines.h:150:0:
cpu.h:176:15: warning: 'BIGFLOAT' defined but not used [-Wunused-variable]
const realnum BIGFLOAT = numeric_limits<realnum>::max()/realnum(100.f);
^
cpu.h:206:26: warning: 'mode_rb' defined but not used [-Wunused-variable]
const ios_base::openmode mode_rb = mode_r | ios_base::binary;
^
cpu.h:207:26: warning: 'mode_wb' defined but not used [-Wunused-variable]
const ios_base::openmode mode_wb = mode_w | ios_base::binary;
^
cpu.h:208:26: warning: 'mode_ab' defined but not used [-Wunused-variable]
const ios_base::openmode mode_ab = mode_a | ios_base::binary;
^
cpu.h:209:26: warning: 'mode_rpb' defined but not used [-Wunused-variable]
const ios_base::openmode mode_rpb = mode_rp | ios_base::binary;
^
cpu.h:210:26: warning: 'mode_wpb' defined but not used [-Wunused-variable]
const ios_base::openmode mode_wpb = mode_wp | ios_base::binary;
^
cpu.h:211:26: warning: 'mode_apb' defined but not used [-Wunused-variable]
const ios_base::openmode mode_apb = mode_ap | ios_base::binary;
^
In file included from cddefines.h:1311:0:
physconst.h:135:14: warning: 'SQAS_SKY' defined but not used [-Wunused-variable]
const double SQAS_SKY = PI4*SQAS1SR;
^
physconst.h:150:14: warning: 'ELECTRIC_CONST' defined but not used [-Wunused-variable]
const double ELECTRIC_CONST = 1.e11/(PI4*pow2(SPEEDLIGHT));
^
physconst.h:198:14: warning: 'HNU3C2' defined but not used [-Wunused-variable]
const double HNU3C2 = 2.*HPLANCK*SPEEDLIGHT*pow3(RYD_INF);
^
physconst.h:210:14: warning: 'STEFAN_BOLTZ' defined but not used [-Wunused-variable]
const double STEFAN_BOLTZ = pow2(PI*pow2(BOLTZMANN))/(60.*pow3(H_BAR)*pow2(SPEEDLIGHT));
^
physconst.h:222:14: warning: 'BOHR_RADIUS_CM' defined but not used [-Wunused-variable]
const double BOHR_RADIUS_CM = FINE_STRUCTURE/(PI4*RYD_INF);
^
physconst.h:225:14: warning: 'TWO_PHOT_CONST' defined but not used [-Wunused-variable]
const double TWO_PHOT_CONST = 9.*pow3(FINE_STRUCTURE2)*FR1RYD/2048.;
^
physconst.h:229:14: warning: 'COLL_CONST' defined but not used [-Wunused-variable]
const double COLL_CONST = SAHA*BOLTZMANN/HPLANCK;
^
physconst.h:233:14: warning: 'MILNE_CONST' defined but not used [-Wunused-variable]
const double MILNE_CONST = SPEEDLIGHT*sqrt(pow3(FINE_STRUCTURE2)*pow3(TE1RYD)/PI);
^
physconst.h:237:14: warning: 'TRANS_PROB_CONST' defined but not used [-Wunused-variable]
const double TRANS_PROB_CONST = PI4*HPLANCK*FINE_STRUCTURE/ELECTRON_MASS;
^
Makefile:196: recipe for target 'maincl.o' failed
make[2]: *** [maincl.o] Error 1
make[2]: Leaving directory '/build/cloudy-13.03/source'
Makefile:2: recipe for target 'main' failed
make[1]: *** [main] Error 2
make[1]: Leaving directory '/build/cloudy-13.03'
dh_auto_build: make -j1 returned exit code 2
debian/rules:8: recipe for target 'build' failed
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2
I: copying local configuration
E: Failed autobuilding of package
W: no hooks of type C found -- ignoring
I: unmounting /var/cache/pbuilder/ccache filesystem
I: unmounting dev/pts filesystem
I: unmounting run/shm filesystem
I: unmounting proc filesystem
-> Cleaning COW directory
forking: rm -rf /var/cache/pbuilder/build/cow.14293
Reply to: