[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: New speakup-udeb component



Hello,

Ok, I'm the culprit, I should have talked about it with debian-boot.

I thought about putting the scripts (attached to this mail) in a
separate speakup-udeb package because it makes the integration to
the debian installer extremely simple: just add speakup-deb to
installer/build/pkg-list/something/somearchs.cfg and voilà.  The idea
was also that in case we needed to change anything, we just had to
upload a new speakup source package.

Frans Pop, le Wed 28 May 2008 18:07:37 +0200, a écrit :
> It seems that this is only a very minimal udeb (only three hook scripts) and 
> we're wondering if there is really a justification to have a separate udeb 
> for that.

Possibly not, see attached files: speakup-udeb.startup gets run early,
sees the speakup statement on the kernel command line, and in that
case modprobes speakup and disables the framebuffer.  In addition to
that, speakup-udeb.debinst selects the text frontend.  Eventually,
speakup-udeb.finish-install installs the module on the target system,
and sets the module to be auto-loaded on reboot.

> 1) The scripts would possibly fit fine in the rootskel and/or finish-install
>    udebs.

Yes.

> 2) There would be a change in D-I needed anyway to get your udeb included in
>    images.

Right.

> 3) Having a udeb in a source package has a cost: it is blocked by default
>    for migrations to testing and causes some release management overhead.

And that's where I indeed think I was wrong.  That would make the
upcoming git speakup releases a burden, while the udeb scripts will
probably not change.

> - is there a real reason these scripts need to be in a separate udeb (one
>   reason could be because they may need to be updated with upstream changes
>   in the same source package;

These scripts will actually probably just stay the same.

> another could be that they should not be included for all installation
> methods)

The scripts by themselves should be fine. The problem is more about
room.  Speakup modules need a total of 160KB. If that's fine with any
installation medium, then great, we can just always enable it. We could
also always have the script, and include the modules only in the cases
where we can afford it.  Scrips will just not work when the modules are
not available.

> - how were you planning to use these scripts: what images and what
>   architectures; did you already have a patch for D-I to include them

Attached is the patch I've been using for tests, just adding the udeb to
a few archs.  In principle, there is no reason to restrain from shipping
speakup to all archs.  It's rather about the room constraints.

Samuel
SYNTH=`sed < /proc/cmdline -n -e 's/.* speakup\.synth=\([^ ]*\).*/\1/p'`
if [ -n "$SYNTH" ]
then
	modprobe speakup_$SYNTH
	debconf-set debian-installer/framebuffer false
fi
SYNTH=`sed < /proc/cmdline -n -e 's/.* speakup\.synth=\([^ ]*\).*/\1/p'`
if [ -n "$SYNTH" ]
then
	DEBIAN_FRONTEND=text
	export DEBIAN_FRONTEND
fi
SYNTH=`sed < /proc/cmdline -n -e 's/.* speakup\.synth=\([^ ]*\).*/\1/p'`
if [ -n "$SYNTH" ]
then
	if apt-install speakup-modules 1>&2
	then
		echo speakup_$SYNTH >> /target/etc/modules
	fi
fi
Index: build/boot/x86/f8.txt
===================================================================
--- build/boot/x86/f8.txt	(r�vision 53132)
+++ build/boot/x86/f8.txt	(copie de travail)
@@ -12,6 +12,7 @@
 Force static network config             0fnetcfg/disable_dhcp=true07
 Set keyboard map                        0fbootkbd=es07
 Use Braille tty                         0fbrltty=driver,device,texttable07
+Use Speakup                             0fspeakup.synth=driver07
 Use high contrast accessibility theme   0ftheme=dark07
 Select the kde or xfce desktops         0fdesktop=kde07
 
Index: build/pkg-lists/netboot/alpha.cfg
===================================================================
--- build/pkg-lists/netboot/alpha.cfg	(r�vision 53132)
+++ build/pkg-lists/netboot/alpha.cfg	(copie de travail)
@@ -26,3 +26,5 @@
 brltty-udeb
 serial-modules-${kernel:Version} ?
 usb-serial-modules-${kernel:Version} ?
+
+speakup-udeb
Index: build/pkg-lists/netboot/i386.cfg
===================================================================
--- build/pkg-lists/netboot/i386.cfg	(r�vision 53132)
+++ build/pkg-lists/netboot/i386.cfg	(copie de travail)
@@ -37,3 +37,5 @@
 brltty-udeb
 serial-modules-${kernel:Version}
 usb-serial-modules-${kernel:Version} ?
+
+speakup-udeb
Index: build/pkg-lists/netboot/ppc64.cfg
===================================================================
--- build/pkg-lists/netboot/ppc64.cfg	(r�vision 53132)
+++ build/pkg-lists/netboot/ppc64.cfg	(copie de travail)
@@ -25,5 +25,7 @@
 serial-modules-${kernel:Version}
 usb-serial-modules-${kernel:Version} ?
 
+speakup-udeb
+
 # IBM Power hypervisor modules, only available on powerpc64.
 hypervisor-modules-${kernel:Version} ?
Index: build/pkg-lists/netboot/ia64.cfg
===================================================================
--- build/pkg-lists/netboot/ia64.cfg	(r�vision 53132)
+++ build/pkg-lists/netboot/ia64.cfg	(copie de travail)
@@ -16,3 +16,5 @@
 brltty-udeb
 serial-modules-${kernel:Version}
 usb-serial-modules-${kernel:Version} ?
+
+speakup-udeb
Index: build/pkg-lists/netboot/amd64.cfg
===================================================================
--- build/pkg-lists/netboot/amd64.cfg	(r�vision 53132)
+++ build/pkg-lists/netboot/amd64.cfg	(copie de travail)
@@ -38,3 +38,5 @@
 brltty-udeb
 serial-modules-${kernel:Version} ?
 usb-serial-modules-${kernel:Version} ?
+
+speakup-udeb
Index: build/pkg-lists/netboot/powerpc.cfg
===================================================================
--- build/pkg-lists/netboot/powerpc.cfg	(r�vision 53132)
+++ build/pkg-lists/netboot/powerpc.cfg	(copie de travail)
@@ -25,6 +25,8 @@
 serial-modules-${kernel:Version}
 usb-serial-modules-${kernel:Version} ?
 
+speakup-udeb
+
 # IBM Power hypervisor modules, only available on powerpc64.
 hypervisor-modules-${kernel:Version} ?
 fancontrol-modules-${kernel:Version} ?

Reply to: