[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [buildd-tools-devel] Bug#696840: same for upload_queues

On Sun, Dec 30, 2012 at 03:47:30PM +0000, Thorsten Glaser wrote:
> Wouter Verhelst dixit:
> >What do you mean by "changed"? The example in my previous mail, as well
> >as on wiki.debian.org, shows that you need to use (), not [], to
> >construct the options...
> Yes, but I decided to take the sample config from the package
> in sid as baseline and apply the instructions from you, the
> Wiki, the buildd.d.o page and Stephen’s mail from 2008 only as
> suggestions (it did turn out that a lot of changes and settings
> are redundant or no longer exist).
> The sample config uses $ and [], and rleigh insisted earlier in
> IRC that that was the new style to use. I said, fine, but only
> once it actually works ;-)

Just to clear up any confusion:

In both sbuild and buildd, we changed the internal configuration
(Buildd::Conf and Sbuild::Conf classes) to *only* use scalars,
which makes it possible to handle all configuration sanely and
also for every option to be undefined and have default properties
which will be used if undefined etc.  There are some other
reasons as well, but the main point is that internally, all
configuration data is a scalar (which includes arrayrefs and
hashrefs).  These are not recent changes; it's all at least two
years old and in use on all the other buildds AFAIK.

Externally, in buildd.conf/sbuild.conf, all configuration is
also a scalar, which maps directly onto the internal name->scalar
hashmap.  For backward compatibility, we still support the older
array/hash objects, but this is for compatibility *only*.  The
read() function maps the old configuration onto the new.  For
new setups, there is no reason to use the old format; please just
use the recommended configuration as documented in sbuild.conf
and buildd.conf.

For the distributions list, the syntax changed quite significantly;
see the read() function which handles the conversion.  Philipp Kern
did this work.


  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux    http://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-    GPG Public Key      F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800

Reply to: