Re: Bug#217845: verbosity fixes for -quiet mode
Hello,
This bug#217845 reported in the bug-tracking system of the Debian
GNU/Linux distribution, http://bugs.debian.org/217845
On Mon, Oct 27, 2003 at 06:59:37PM +0100, Oskar Liljeblad wrote:
> Package: mkisofs
> Version: 4:2.0+a19-2
[...]
> This patch removes some annoying information output when -quiet is enabled.
> If you look at the patch you will also notice that a leading newline was
> removed from one of the fprintfs -
> fprintf(stderr, "Size of [..]
> instead of
> fprintf(stderr, "\nSize of [..]
> I found no reason why this \n should be there. Every time I ran mkisofs
> it just resulted in an empty line just above, and the code gives no
> indication that it is used to terminate a line previously printed without
> newline.
[DeMIMEd]:
-----------------------------------
diff -u -p mkisofs/eltorito.c.v0 mkisofs/eltorito.c
--- mkisofs/eltorito.c.v0 2003-10-27 18:17:23.000000000 +0100
+++ mkisofs/eltorito.c 2003-10-27 18:23:38.000000000 +0100
@@ -374,12 +374,14 @@ fill_boot_desc(boot_desc_entry, boot_ent
nsectors = boot_entry->load_size ? boot_entry->load_size :
ISO_BLOCKS(de->size) * (SECTOR_SIZE/512);
- fprintf(stderr, "\nSize of boot image is %d sectors -> ", nsectors);
+ if (verbose > 0)
+ fprintf(stderr, "Size of boot image is %d sectors -> ", nsectors);
if (boot_entry->hard_disk_boot) {
/* sanity test hard disk boot image */
boot_desc_entry->boot_media[0] = EL_TORITO_MEDIA_HD;
- fprintf(stderr, "Emulating a hard disk\n");
+ if (verbose > 0)
+ fprintf(stderr, "Emulating a hard disk\n");
/* read MBR */
bootmbr = open(de->whole_name, O_RDONLY | O_BINARY);
@@ -505,21 +507,25 @@ fill_boot_desc(boot_desc_entry, boot_ent
* in the boot image
*/
boot_desc_entry->boot_media[0] = EL_TORITO_MEDIA_NOEMUL;
- fprintf(stderr, "No emulation\n");
+ if (verbose > 0)
+ fprintf(stderr, "No emulation\n");
} else {
/* choose size of emulated floppy based on boot image size */
if (nsectors == 2880) {
boot_desc_entry->boot_media[0] = EL_TORITO_MEDIA_144FLOP;
- fprintf(stderr, "Emulating a 1440 kB floppy\n");
+ if (verbose > 0)
+ fprintf(stderr, "Emulating a 1440 kB floppy\n");
} else if (nsectors == 5760) {
boot_desc_entry->boot_media[0] = EL_TORITO_MEDIA_288FLOP;
- fprintf(stderr, "Emulating a 2880 kB floppy\n");
+ if (verbose > 0)
+ fprintf(stderr, "Emulating a 2880 kB floppy\n");
} else if (nsectors == 2400) {
boot_desc_entry->boot_media[0] = EL_TORITO_MEDIA_12FLOP;
- fprintf(stderr, "Emulating a 1200 kB floppy\n");
+ if (verbose > 0)
+ fprintf(stderr, "Emulating a 1200 kB floppy\n");
} else {
#ifdef USE_LIBSCHILY
-----------------------------------
Thoughts, comments?
cu andreas
PS: Please cc 217845@bugs.debian.org on followups.
Reply to: