[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: "Minor" changes to libconfig-inifiles-perl package (and including new upstream version)



-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160

On Sat, May 30, 2009 at 11:42:40PM +0200, Salvatore Bonaccorso wrote:
>> >> >N: Processing binary package libconfig-inifiles-perl (version 2.49-1) ...

>I shortly investigated the problem and on line 2464 I think there is a 
>=cut part which shouldn't be, as it does not seem correct. =cut should 
>"close" a pod block, but there wasn't a real such block on the last 
>part of lib/Config/IniFiles.pm!
>
>In source this should happen: 
>Index: lib/Config/IniFiles.pm
>===================================================================
>--- lib/Config/IniFiles.pm	(revision 36865)
>+++ lib/Config/IniFiles.pm	(working copy)
>@@ -2461,10 +2461,6 @@
> 
> 1;
> 
>-=cut
>-
>-1;
>-
> # Please keep the following within the last four lines of the file
> #[JW for editor]:mode=perl:tabSize=8:indentSize=2:noTabs=true:indentOnEnter=true:
>

Ah, yes.

Here's how to apply that patch the CDBS way - in case you want to know:

  1) copy debian/patches/README from libhtml-wikiconverter-markdown-perl

  2) add patch as e.g. 1001_fix_pod.patch

  3) generate series:

     cd debian/patches; ls -1 0* 1* 2* > series

  4) include /usr/share/cdbs/1/rules/patchsys-quilt.mk in debian/control

  5) update copyright hints and resolve dependencies:

     DEB_MAINTAINER_MODE=1 fakeroot debian/rules pre-build
     DEB_MAINTAINER_MODE=1 fakeroot debian/rules clean
     mv debian/copyright_newhints debian/copyright_hints

  6) Check that you agree with generated changes:

     svn diff

That last step is important (no matter if you are dealing with CDBS or 
other helper tools): Ultimately you are responsible for what you do - a 
broken tool can explain collateral damage but not (in principle) excuse 
it.


Hope that helps.  And hope you still want to work with CDBS :-)


  - Jonas

- -- 
* Jonas Smedegaard - idealist og Internet-arkitekt
* Tlf.: +45 40843136  Website: http://dr.jones.dk/

  [x] quote me freely  [ ] ask before reusing  [ ] keep private
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEAREDAAYFAkohuv0ACgkQn7DbMsAkQLgycwCfQuXLrDW0Zhxvyb9Ax7/6lVT3
N6MAn0nferduRL3+AQeDO01LSU3EtMpu
=p8VN
-----END PGP SIGNATURE-----


Reply to: