Re: RFS: conque

[Jakub Wilk <jwilk@debian.org>]

* harish badrinath <harishbadrinath@gmail.com>, 2011-10-04, 03:03:
> http://mentors.debian.net/package/conque
>
> Alternatively, one can download the package with dget using this command:
>
> dget -x http://mentors.debian.net/debian/pool/main/c/conque/conque_2.3-1.dsc
[snip]
> > > Now the package description reads
> > > <snip>
> > > Or you could just use his text verbatim, which will make me
> DONE

That's still not quite right. The description field consist of two 
parts: short description (the first line) and long description (the 
following lines). The following lines are *not* supposed to be 
continuation of the first line.

> use the appropriate helper --with dh_python2 and also rewrote the
> debian/rules file

The call to dh_python2 in line 10 is spurious. The "--with python2" 
option is also essentially a no-op[0].

It would make sense to pass /usr/share/vim/addons/autoload/conque_term/ 
to dh_python2, rather than /usr/share/vim/addons/. Firstly, it'll make 
this a little bit faster. Secondly, it'll make your package more 
backportable[1].

Other than that, it looks good. (I normally don't sponsor stuff using
dh_python2, but meh...)


[0] "--with python2" only inserts dh_python2 (without any arguments) to 
the dh command chain. But for your package such a call does nothing.

[1] It seems that older versions of dh_python2 (including the squeeze 
one) has a bug, that makes the rtupdate script bytecompile all files 
from the requested directory, even when they don't belong to the 
package.

--
Jakub Wilk