Re: Proposed hook to tag bugs as pending
On Thu, 26 Mar 2009, Adeodato Simó wrote:
> Now, if one wanted to write a hook that actually catered for both
> workflows, what would one do? Does anybody has suggestions? It is
> certainly doable to parse the commit message for Closes, and act only on
> those bugs if any, and if there are not any, look at the changelog. (I
> think it’s reasonable not looking at debian/changelog it the commit
> message mentions a bug number.)
That looks reasonable, yes.
> However, this will behave horribly when the run of git-dch or whatever
> tool is committed, since it will want to mark all the bugs as pending
> again; that’s the part where I need suggestions. I’d rather not have the
> hook need any configuration, and making it stateful is definitely out of
> questions. Maybe it should treat the bug numbers from debian/changelog
> as “untrusted”, and only send the message if they are not tagged pending
> already (by doing a SOAP request)?
Most probably yes. You would have similar problems when merging branches
too. In the dpkg repo we merged the lenny branch in master regularly and
it would have lead to the same problem as the commits would have been
scanned twice (once while pushing lenny and once while pushing master).
Cheers,
--
Raphaël Hertzog
Contribuez à Debian et gagnez un cahier de l'admin Debian Lenny :
http://www.ouaza.com/wp/2009/03/02/contribuer-a-debian-gagner-un-livre/
Reply to: