[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: micro-evtd: udeb (arm armel only)



+# Test if device is supported
+machine=`sed -n '/Hardware/ {s/^Hardware\s*:\s//;p}' /proc/cpuinfo`
+case $machine in
+	"Buffalo/Revogear Kurobox Pro")
+		# Success or continue
+		exit 0 || true
+		;;
+	*)
+		# Failure or silently exit
+		exit 1 || exit 0
+		;;

I just checked if you did a check if the system is supported (especially 
important for the udeb!) and the code above seems to be it.

But 'exit 0 || true' and 'exit 1 || exit 0' really don't make sense...
Seems to have been copied from my code, but without the preceding test it 
really does not make sense. If you don't need the test you should 
probably just have:

+# Test if device is supported
+machine=`sed -n '/Hardware/ {s/^Hardware\s*:\s//;p}' /proc/cpuinfo`
+case $machine in
+	"Buffalo/Revogear Kurobox Pro")
+		: ;;
+	*)
+		# Silently exit
+		exit 0 ;;

Cheers,
FJP

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: