[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#939886: review



Old Package Name [1]
but i am using ~exp1 [2]
pacvim_1.1.1-1~exp1

[1] https://mentors.debian.net/package/pacvim
[2] https://mentors.debian.net/debian/pool/main/p/pacvim/pacvim_1.1.1-1~exp1.dsc

On Mon, Jan 13, 2020 at 9:58 PM Ko Ko Ye` <kokoye2007@gmail.com> wrote:
Done. 

1) 
Copyright: 2015 Jamal Moon
2)
remove upstream-contact
3)
override_dh_fixperms:
        dh_fixperms
        chmod 644 debian/pacvim/usr/share/pacvim-maps/*
4)
we have error 
file-contains-trailing-whitespace
debian/rules (line 9)
now fix and reuplaod again.

check and guide me pls.



On Mon, Jan 13, 2020 at 9:09 PM Kyle Robbertze <paddatrapper@debian.org> wrote:
On 2020/01/13 16:29, Ko Ko Ye` wrote:
> I have done
> 1) copyright file, maybe its cache.
It isn't.
> Files: *
> Copyright: 2015 jmoon018

This line should be
Copyright: 2015 Jamal Moon

> License: LGPL-3.0+
>
> Files: debian/*
> Copyright: 2020 kokoye2007 <kokoye2007@gmail.com
> <mailto:kokoye2007@gmail.com>>
> License: LGPL-3.0+
>
> 2) i change
>
> Upstream-Contact: kokoye2007 <kokoye2007@gmail.com
> <mailto:kokoye2007@gmail.com>>
>

I don't understand, have you made yourself the upstream contact? This
line should read:
Upstream-Contact: Jamal Moon <some-email>

I do see that they has not chosen to show an email on GitHub, so you may
want to remove this line completely.

> 3) change permission
>
> drwxr-xr-x 2 kokoye2007 kokoye2007 4096 Sep  9 20:15 .
> drwxr-xr-x 6 kokoye2007 kokoye2007 4096 Jan 13 20:44 ..
> -rw-r--r-- 1 kokoye2007 kokoye2007  422 Sep  9 20:15 map0.txt
> -rw-r--r-- 1 kokoye2007 kokoye2007  394 Sep  9 20:15 map1.txt
> -rw-r--r-- 1 kokoye2007 kokoye2007  219 Sep  9 20:15 map2.txt
> -rw-r--r-- 1 kokoye2007 kokoye2007  684 Sep  9 20:15 map3.txt
> -rw-r--r-- 1 kokoye2007 kokoye2007 1450 Sep  9 20:15 map4.txt
> -rw-r--r-- 1 kokoye2007 kokoye2007  460 Sep  9 20:15 map5.txt
> -rw-r--r-- 1 kokoye2007 kokoye2007  974 Sep  9 20:15 map6.txt
> -rw-r--r-- 1 kokoye2007 kokoye2007  342 Sep  9 20:15 map7.txt
> -rw-r--r-- 1 kokoye2007 kokoye2007 1153 Sep  9 20:15 map8.txt
> -rw-r--r-- 1 kokoye2007 kokoye2007  190 Sep  9 20:15 map9.txt
>

Changing them on your local machine will not change the installed
permissions. You need to use dh-fixperms in your debian/rules to address
this issue.


--
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ Kyle Robbertze
⢿⡄⠘⠷⠚⠋⠀ Debian Developer
⠈⠳⣄⠀⠀⠀⠀ https://wiki.debian.org/KyleRobbertze



--


--

Reply to: