[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#948261: review



fonts-myanmar_0.0-1~exp1[1] is ready on mentor [2]
   * First Update for Upstream
   * ITP: fonts-myanmar (Close: #899260)
   * ITP: ITP: ttf-myanmar-fonts (Close: #896887)

[1] https://mentors.debian.net/debian/pool/main/f/fonts-myanmar/fonts-myanmar_0.0-1~exp1.dsc

[2] https://mentors.debian.net/package/fonts-myanmar

On Mon, Jan 13, 2020 at 8:49 PM Kyle Robbertze <paddatrapper@debian.org> wrote:
On 2020/01/13 14:00, Ko Ko Ye` wrote:
>
>
> On Mon, Jan 13, 2020 at 3:42 PM Kyle Robbertze <paddatrapper@debian.org
> <mailto:paddatrapper@debian.org>> wrote:
>
>     Control: tags -1 moreinfo
>
>     Hi,
>
>     Is the homepage and copyright correct in this package? i.e. are you the
>     upstream developer of these fonts?
>
>
> Its difference Developer
> but i add debian/copyright at font by font developer name and license
> (all is SIL 1.1)
>
>
>     Also the packages are not lintian clean:
>
>      > W: fonts-myanmar: empty-binary-package
>     This package should depend on the other packages, not recommend them
>     and include the fact that it is a metapackage in the long description.
>
>
> Now Remove it.
>
>
>      > W: fonts-myanmar-angoun:
>     truetype-font-prohibits-installable-embedding [edit only]
>     usr/share/fonts/truetype/mm/MyanmarAngoun.ttf
>
>     See fsType in the official spec [1]
>
>     [1]
>     https://developer.apple.com/fonts/TrueType-Reference-Manual/RM06/Chap6OS2.html#fsType
>
>
> Now I am remove this package "fonts-myanmar-angoun"
> its fork from Montserrat [1]
> we learn and add after fix.

All the packages are like this, I just pulled the first example of the
error message. It is fine, I am happy to upload with this error for the
moment and you can work with upstream to fix it.

Your changelog needs to close the ITP bug for this package. This is
currently missing. i.e. there should be (Close: #899260) in the
changelog entry.

You can remove the debian/compat file, as you are using debhelper-compat
in debian/control.

With those changes, I'll be happy to upload for you. Note the package
will have to go through the NEW queue, so will require two uploads - one
binary upload now and a second source upload after it goes through NEW.
I suggest you make this package target experimental and make the version
0.0-1~exp1. Then once it is through new, ping me to upload 0.0-1 to
unstable.

Cheers
Kyle

--
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ Kyle Robbertze
⢿⡄⠘⠷⠚⠋⠀ Debian Developer
⠈⠳⣄⠀⠀⠀⠀ https://wiki.debian.org/KyleRobbertze


--

Reply to: