[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#864241: RFS: pnmixer/0.7.2-1 -- Simple mixer application for system tray



Hi Paul, thx for the review.

>
>> The package is now built with `gbp` from a git tag. I guess it fixes the problem.
> Please verify that is the case.

Well, I'm not a 100% sure that I'm doing it right here. Let me explain
the situation.

PNMixer switched to CMake, so there is no more 'make dist'. PNMixer now uses
'git archive' to create the archive that is released on GitHub.

On the Debian packaging side, I use gbp now, and I package from a git
tag. I DO
NOT use pristine-tar. When I use 'gbp buildpackage' on my machine, gbp
creates
the original archive from the git source at a given tag. And that is
what I uploaded
to mentors.

Is it a correct way of doing things ?

> That is a shame, you might want to mention in the README that the XCF
> files were lost so now any modifications will be to the PNG files.

Yep, I can add that too the README.

> I think you may have misunderstood the point of my blog post, it is
> more about shell metacharacter injection attacks.

Ok thanks for the clarification, I read the article a while ago, I'll
have to check that again.

> Please consider running lintian/check-all-the-things/etc as often as
> you can (such as before each release or before every commit) and
> chipping away at the issues when you have time.

Ok lah.

Cheers,
  Arnaud.


Reply to: