Bug#864241: RFS: pnmixer/0.7.2-1 -- Simple mixer application for system tray
Package: sponsorship-requests
Severity: normal
Dear mentors,
I am looking for a sponsor for my package "pnmixer"
* Package name : pnmixer
Version : 0.7.2-1
Upstream Author : Nick Lanham, Julian Ospald, Arnaud Rebillout
* URL : https://github.com/nicklan/pnmixer
* License : GPLv3
Section : sound
It builds those binary packages:
pnmixer - Simple mixer application for system tray
To access further information about this package, please visit the following URL:
https://mentors.debian.net/package/pnmixer
Alternatively, one can download the package with dget using this command:
dget -x https://mentors.debian.net/debian/pool/main/p/pnmixer/pnmixer_0.7.2-1.dsc
More information about pnmixer can be obtained from https://github.com/nicklan/pnmixer.
Changes since the last upload:
* New upstream release.
- Switch to cmake buildsystem.
- Use gettext instead of intltool for translation.
- Build is now reproducible. Closes: #854112.
* Update watchfile to version 4.
* Package is now versioned with git and build with gbp. See the control file for the url.
Additional notes
For the last release, Paul Wise made a thorough review, and I failed to reply in time (see #839289). So I will reply now.
> The file downloaded by uscan is different to the one you have included in your Debian source package. Please adjust your debian/watch file to use the correct one.
Done, the watch file seem to work according to `uscan`, but mentors.debian.net says there's a problem. I'm not sure what's wrong.
> I suggest that you try and make the github generated tarball as similar as possible to the `make dist` generated tarball.
The package is now built with `gbp` from a git tag. I guess it fixes the problem.
> The debian/watch tells uscan that v0.7-rc1 is newer than v0.7. I think you want uversionmangle=s/-rc/~rc/.
Yes indeed, fixed, thanks.
> The images say they were produced in GIMP and look like multi-layer images that have been rendered to flat bitmaps, did you discard the XCF images or are they hidden away somewhere? How were these images produced? In general it is best to render final images from the source material at build time, using xcf2png or similar.
I have no idea where are the source images, when I jumped in PNMixer development there was only the PNG files, and I don't think the XCF files will ever be found.
> Generated and stamp files should be removed from the upstream git repo and added to .gitignore:
Done.
> I expect most of autogen.sh can be replaced with a call to autoreconf:
We switched to CMake in the end, no more autotools.
> Running wrap-and-sort would make diffs of the Debian packaging easier to read
Done, thx for the command.
> The system() and g_spawn_command_line_async() functions should not be used and I don't think `which` is very portable. Instead of system()+`which` you should use g_find_program_in_path().
Done, thx, I didn't know about this function.
> Instead of g_spawn_command_line_async() you should use g_spawn_async().
Sorry, disagreeing on this one, g_spawn_command_line_async() is definitely what I want to use, it's the right tool for the job. And if the implementation is bad and uses too many pid, no worries. In PNMixer, this function is rarely called, probably never called. But in other situations, if ever we made an extensive use of this function, then I would probably agree with you and use g_spawn_async().
> Please add some upstream metadata
Done.
> Since you are upstream, please read our guide for upstreams
Oups, reading now :)
> Automatic checks
Fixed a few things, but there's way too much stuff there, I didn't take time to look through everything. For the next release :)
Best regards,
Arnaud Rebillout
Reply to: