tags 849627 - moreinfo thanks Hello Sean, Am Donnerstag, den 29.12.2016, 22:16 +0000 schrieb Sean Whitton: > control: tag -1 +moreinfo > > Hello Jörg, > > On Thu, Dec 29, 2016 at 07:03:26PM +0100, Jörg Frings-Fürst wrote: > > first thanks for your first review. > > No problem. > > I've now taken a proper look at your copyright file. Some problems: > > - the "FreeBSD" license has a standard shortname: BSD-2-clause > changed > - did you make up the 'mixed', 'BSD-Revised' and 'permissive' license > shortnames? I suspect there are standard names -- try > http://codesearch.debian.net > I have change * BSD-Revised to BSD-1-Clause * mixed to BSD-like-with-advertising-clause permissive I have found at[1], but also a lot of other license text with the same name. So I ask debian-legal[2]. > - you can't claim 2017 copyright on debian/ since we will upload this > before 2017 begins :) ok I have removed the 2017 :-) > > - if you run `licensecheck --copyright -r .` you will find many files > that are Copyright 2005 David Bullis. Maybe you should add this to > the "Files: *" stanza? > > - Mikko Nissinen also holds copyright on app/i18n/stripmsg.c > > - copyright years for getopt.*, uthash.h, gwin32.c, mswbitmap.c and > others are wrong -- why did you add '-2015' when the file was not > edited since the earlier year? > I have used the file modification time. > - copyright for app/tools/halibut/charset/macenc.c wrong > I have checked and changed: * Add David Bullis to Files: * and remove the stanzas with only him as copyright holder. * Use only the year(s) written into the files. * Add missing stanzas. > > > > Changes since the last upload: > > > > > > > > * New Maintainer (Closes: #849139): > > > > - debian/control: Add myself as maintainer. > > > > - debian/copyright: Add myself to debian/*. > > > > * New upstream release (Closes: #847843, #784423). > > > > > > In #847843, Mike Gabriel suggests team maintenance of xtrkcad. Have you > > > got in touch with him about maintaining xtrkcad together? Is he aware > > > of your ITA? #847843 is itself almost an ITA, and it was submitted only > > > very recently, so you should be sure that your upload doesn't treat on > > > Mike's toes. > > > > > > > My mistake. I have only skimmed through the text. I have ask Mike per > > mail and add him as Uploader. > > Great. I suggest writing "(Closes: #847843)" next to the Uploader > change -- it is okay to 'close' a bug more than once in a single upload. > Ah. I don't know that I can multiple close a bug at one time. Added. > > > * Remove debian/source/options. > > > > > > Why? > > > > To use the default compression. Comment is added. > > Okay. > > > > > > > > * Remove debian/source.lintian-overrides. > > > > * Change debian/compat to 10 (no changes required). > > > > * debian/control: > > > > - Bump Standards-Version to 3.9.8 (no changes required). > > > > - Bump debhelper B-D minimum version to 10. > > > > - Add Vcs-* tags. > > > > - Change Priority from extra to optional. > > > > > > Just a reminder that you will have to submit a bug against > > > ftp.debian.org to have this actually take effect (post-adoption). > > > > > > > Because of the Priority change? > > > > The change was based on the comment at the old PTS[1]. > > Ah. You could mention this in your changelog, so I wouldn't ask the > question :) E.g. > > - Change Priority from extra to optional. > To match current ftp-master override file. > It is now: Change Priority from extra to optional to match with current ftp-master override file. > > > > * debian/rules: > > > > - Enable hardening. > > > > * New debian/patches/0700-info_file.patch to add requested directory entry > > > > and INFO-DIR-SECTION. > > > > * Rewrite debian/watch to use the sf redirector. > > > > - Add files to exclude in debian/copyright. > > > > * Rewrite debian/copyright. > > > > > > Lintian tags you can easily fix: > > > > > > I: xtrkcad source: vcs-field-uses-insecure-uri vcs-git git://anonscm.debian.org/collab-maint/xtrkcad.git > > > > My option to not change git to https was to start a git-gui client > > directly. If you want I change it. > > Are you saying that git-gui cannot use https URIs? > No. I mean that I want to click on a link the right program should open. > It's okay to keep git:// if it is more convenient for you. > > > > I: xtrkcad: spelling-error-in-binary usr/bin/xtrkcad Minumum Minimum > > > > I have add a new patch 0900-spelling-errors.patch to correct the > > spelling error. > > Thanks, and great work forwarding the patch. > Normally. Or? > > > It looks like you used wrap-and-sort -- please add this to the > > > changelog, so a future contributor knows which options to use. E.g. > > > > > > * Run wrap-and-sort -abst > > You haven't added this to the changelog yet... I don't use this tool.. > > > > > > > You made changes to d/rules not documented in the changelog. > > > > sry. Also I don't have a git commit message. I have add a comment about > > this. > > What do you mean about "git commit message"? > > Changelog for d/rules LGTM. > For me is one of the last work to check all lines of the changelog vs. the git commit messages for missing parts. Comment added. And for your 2. mail: I have moved the html directroy, Readme.txt and logo.bmp to /usr/share/doc/xtrkcad. The other directories (demo, examples, params) contains only data file. I think that /usr/share/xtrkcad is the right place for them. Especially if we want to move the data into a new package in the future. > > > > > > > > > > After making further changes, don't forget to re-run `dch -r`, and > > > please remove the moreinfo tag from this bug to put it back in my queue. > > > > > > > done > > Ditto for this second review. > > We are almost ready to upload. > :-))) Many thanks! CU Jörg [1] https://tracker.debian.org/media/packages/a/atanks/copyright-6.5~dfsg-2 [2] https://lists.debian.org/debian-legal/2016/12/msg00029.html -- New: GPG Fingerprint: 63E0 075F C8D4 3ABB 35AB 30EE 09F8 9F3C 8CA1 D25D GPG key (long) : 09F89F3C8CA1D25D GPG Key : 8CA1D25D CAcert Key S/N : 0E:D4:56 Old pgp Key: BE581B6E (revoked since 2014-12-31). Jörg Frings-Fürst D-54470 Lieser Threema: SYR8SJXB IRC: j_f-f@freenode.net j_f-f@oftc.net My wish list: - Please send me a picture from the nature at your home.
Attachment:
signature.asc
Description: This is a digitally signed message part