[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#849627: RFS: xtrkcad/1:4.2.4a-1 ITA



tags 849627 - moreinfo
thanks

Hello Sean,

first thanks for your first review.

Am Donnerstag, den 29.12.2016, 12:13 +0000 schrieb Sean Whitton:
> control: tag -1 +moreinfo
> 
> Dear Jörg,
> 
> On Thu, Dec 29, 2016 at 10:08:50AM +0100, Jörg Frings-Fürst wrote:
> >   I am looking for a sponsor for my package "xtrkcad"
> 
> I'd like to sponsor this.
> 
> I assume it's okay for me to work out of your collab-maint repo.

ok...

> 
> >   Changes since the last upload:
> > 
> >   * New Maintainer (Closes: #849139):
> >     - debian/control: Add myself as maintainer.
> >     - debian/copyright: Add myself to debian/*.
> >   * New upstream release (Closes: #847843, #784423).
> 
> In #847843, Mike Gabriel suggests team maintenance of xtrkcad.  Have you
> got in touch with him about maintaining xtrkcad together?  Is he aware
> of your ITA?  #847843 is itself almost an ITA, and it was submitted only
> very recently, so you should be sure that your upload doesn't treat on
> Mike's toes.
> 
My mistake. I have only skimmed through the text. I have ask Mike per
mail and add him as Uploader.

>   * Remove debian/source/options.
> 
> Why?

To use the default compression. Comment is added.

> 
> >   * Remove debian/source.lintian-overrides.
> >   * Change debian/compat to 10 (no changes required).
> >   * debian/control:
> >     - Bump Standards-Version to 3.9.8 (no changes required).
> >     - Bump debhelper B-D minimum version to 10.
> >     - Add Vcs-* tags.
> >     - Change Priority from extra to optional.
> 
> Just a reminder that you will have to submit a bug against
> ftp.debian.org to have this actually take effect (post-adoption).
> 

Because of the Priority change?

The change was based on the comment at the old PTS[1].


> >   * debian/rules:
> >    - Enable hardening.
> >   * New debian/patches/0700-info_file.patch to add requested directory entry
> >     and INFO-DIR-SECTION.
> >   * Rewrite debian/watch to use the sf redirector.
> >     - Add files to exclude in debian/copyright.
> >   * Rewrite debian/copyright.
> 
> Lintian tags you can easily fix:
> 
>     I: xtrkcad source: vcs-field-uses-insecure-uri vcs-git git://anonscm.debian.org/collab-maint/xtrkcad.git

My option to not change git to https was to start a git-gui client
directly. If you want I change it.

>     I: xtrkcad: spelling-error-in-binary usr/bin/xtrkcad Minumum Minimum

I have add a new patch 0900-spelling-errors.patch to correct the
spelling error.
> 
> In the future, after the stretch freeze, consider a package split:
> 
>     I: xtrkcad: arch-dep-package-has-big-usr-share 16352kB 92%
> 
> It looks like you used wrap-and-sort -- please add this to the
> changelog, so a future contributor knows which options to use.  E.g.
> 
>     * Run wrap-and-sort -abst
> 
> You made changes to d/rules not documented in the changelog.

sry. Also I don't have a git commit message. I have add a comment about
 this.
 
> 
> After making further changes, don't forget to re-run `dch -r`, and
> please remove the moreinfo tag from this bug to put it back in my queue.
> 
done

Many thanks!

CU
Jörg

[1] https://packages.qa.debian.org/x/xtrkcad.html

-- 
New:
GPG Fingerprint: 63E0 075F C8D4 3ABB 35AB  30EE 09F8 9F3C 8CA1 D25D
GPG key (long) : 09F89F3C8CA1D25D
GPG Key        : 8CA1D25D
CAcert Key S/N : 0E:D4:56

Old pgp Key: BE581B6E (revoked since 2014-12-31).

Jörg Frings-Fürst
D-54470 Lieser

Threema: SYR8SJXB

IRC: j_f-f@freenode.net
     j_f-f@oftc.net

My wish list: 
 - Please send me a picture from the nature at your home.

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: