Bug#848993: RFS: llmnrd/0.2-1 [ITP]
On Fri, Dec 23, 2016 at 09:41:29PM +0100, Pali Rohár wrote:
> On Friday 23 December 2016 14:46:53 Andreas Henriksson wrote:
> > You use DAEMON_OPTS in the default file, while sysvinit seems to be
> > standardizing on DAEMON_ARGS .... to avoid the messy work of later
> > migration of conffile settings you might want to consider switching
> > to DAEMON_ARGS now before the first version has been uploaded. You
> > decide.
>
> Hm... Another option would be to use LLMNRD_OPTS. Looks like other
> daemons in Debian (e.g. ntpd or rsync) use env variable <NAME>_OPTS in
> /etc/default/<name>.
>
> What do you think about it?
The reason to use DAEMON_ARGS is that if you ever where to switch
to init-d-script in the future it would "just work" without
needing messy conversion handling. Your current init scripts seems
to already support DAEMON_ARGS already so it would just be a
case of changing the default file to use DAEMON_ARGS.
Giving it an even more specialized name lite LLMNRD_OPTS seems
like you're expecting environment variable leakage between
different services and that should in my opinion be handled
by fixing the leakage instead.
In the end this is all your choice. I've reviewed your existing
package and is ready to upload as soon as you've decided on
this matter. Poke me asap and there might still be a theoretical
chance of making into stretch (although I basically assume it's
already missed since we need to clear both the NEW queue +
a 10 day migration time before 5 jan - and I don't expect to see
0-day NEW queue handling on christmas).
Regards,
Andreas Henriksson
Reply to: