Bug#848993: RFS: llmnrd/0.2-1 [ITP]
Hi again Pali Rohár,
On Fri, Dec 23, 2016 at 11:29:59AM +0100, Pali Rohár wrote:
> Now lintian on mentors shows warning:
>
> package-uses-experimental-debhelper-compat-version
> 10
Yes, lintian is simply wrong/outdated here. It's just a tool to help you
find issues, don't blindly follow lintian like if it was religion or
policy. Normally you'd consider a lintian override in cases where you
have confirmed lintian is wrong, but in this case the warning will
likely go away by itself if you just give it some time for new lintian
releases to appear.
More importantly I wanted to mention a detail which might be useful to
consider before uploading your package:
You use DAEMON_OPTS in the default file, while sysvinit seems to be
standardizing on DAEMON_ARGS .... to avoid the messy work of later
migration of conffile settings you might want to consider switching to
DAEMON_ARGS now before the first version has been uploaded. You decide.
FYI, I also filed issues upstream for potential systemd service
improvements. #15, #16.
Shipping the file is as simple as running
"echo etc/llmnrd.service >> debian/llmnrd.install"
as dh compat 10 takes care of the rest for you.
You might want to consider dropping the attached patch in
debian/patches/ and adding debian/patches/series containing it's
name to preserve default file configuration under both init systems.
Regards,
Andreas Henriksson
--- a/etc/llmnrd.service
+++ b/etc/llmnrd.service
@@ -4,7 +4,8 @@
[Service]
Type=simple
-ExecStart=/usr/sbin/llmnrd
+EnvironmentFile=-/etc/default/llmnrd
+ExecStart=/usr/sbin/llmnrd $DAEMON_OPTS $DAEMON_ARGS
Restart=on-failure
User=nobody
Group=nogroup
Reply to: