On Friday 23 December 2016 14:46:53 Andreas Henriksson wrote: > Hi again Pali Rohár, > > On Fri, Dec 23, 2016 at 11:29:59AM +0100, Pali Rohár wrote: > > Now lintian on mentors shows warning: > > > > package-uses-experimental-debhelper-compat-version > > 10 > > Yes, lintian is simply wrong/outdated here. It's just a tool to help > you find issues, don't blindly follow lintian like if it was > religion or policy. Normally you'd consider a lintian override in > cases where you have confirmed lintian is wrong, but in this case > the warning will likely go away by itself if you just give it some > time for new lintian releases to appear. > > More importantly I wanted to mention a detail which might be useful > to consider before uploading your package: > > You use DAEMON_OPTS in the default file, while sysvinit seems to be > standardizing on DAEMON_ARGS .... to avoid the messy work of later > migration of conffile settings you might want to consider switching > to DAEMON_ARGS now before the first version has been uploaded. You > decide. Hm... Another option would be to use LLMNRD_OPTS. Looks like other daemons in Debian (e.g. ntpd or rsync) use env variable <NAME>_OPTS in /etc/default/<name>. What do you think about it? > FYI, I also filed issues upstream for potential systemd service > improvements. #15, #16. > Shipping the file is as simple as running > "echo etc/llmnrd.service >> debian/llmnrd.install" Yes, I know. But first we need fully working service file. > as dh compat 10 takes care of the rest for you. > You might want to consider dropping the attached patch in > debian/patches/ and adding debian/patches/series containing it's > name to preserve default file configuration under both init systems. > > Regards, > Andreas Henriksson -- Pali Rohár pali.rohar@gmail.com
Attachment:
signature.asc
Description: This is a digitally signed message part.