Hello,
On Wed, Aug 24, 2016 at 12:37:12PM -0700, Sean Whitton wrote:
> > Hold on, are you looking at upstream copyright file?
> > That file is outdated and not used. Please check the file on Debian branch:
> >
> > https://github.com/hosiet/nixnote2/blob/debian/debian/copyright
>
> I was looking at the wrong file -- sorry for being sloppy and wasting
> your time. Unfortunately, there are some problems with the one you've
> linked to.
There's a further issue with at least some of the files in images/. The
check-all-the-things tool reveals:
# Check with upstream where the GIMP XCF source files are.
$ find -type f \( -iname '*.png' -o -iname '*.gif' -o -iname '*.jpg' -o -iname '*.jpeg' \) -exec grep -iF gimp {} +
Binary file ./images/purple-theme/synchronize.png matches
i.e. images/purple-theme/synchronize.png was probably created with the
GIMP. That means the preferred format for modifying this file is
probably a *.svg file. Similarly, the other files in the theme might
have been prepared with a tool that works with *.svg files and exports
to *.png.
In order to satisfy DFSG (and indeed the GPL), the *.svg files need to
be included in the source package.
I think you need to patch readme.txt to remove reference to installation
instructions, since (rightly) you're not installing install.txt and
Readme_Arch_Linux.txt.
Finally, it seems that spellchecker.cpp hardcodes paths to OpenOffice
dictionaries in /opt. They're not installed to /opt on Debian. And
maybe you need a dependency on libreoffice.
--
Sean Whitton
Attachment:
signature.asc
Description: PGP signature