[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#835286: RFS: mmh/0.3-1 ITP



New version on mentors.

> Please include the upstream tarball signature alongside the upstream
> tarball. uscan doesn't yet put it in the right place, but it should be
> named mmh_0.3.orig.tar.gz.asc and dpkg-buildpackage will include it
> into the .dsc file.

I did it, but I see no change. Here is parent directory of source package:

	mmh/
	mmh-0.3.tar.gz.pgp
	mmh-HEAD-49f9381/
	mmh-dbgsym_0.3-1_amd64.deb
	mmh-git/
	mmh_0.3-1.debian.tar.xz
	mmh_0.3-1.dsc
	mmh_0.3-1_amd64.changes
	mmh_0.3-1_amd64.deb
	mmh_0.3-1_amd64.mentors.upload
	mmh_0.3.orig.tar.gz
	mmh_0.3.orig.tar.gz.asc

I use dpkg/jessie.

> sbr/dtimep.c is a generated file (using flex I think), please remove
> it in `debian/rules build` before ./configure is run so that we know
> we can build it from source. You'll probably need to also remove it in
> `debian/rules clean`. I found this using licensecheck.

Fixed.

> I don't think this is needed in the patches, just the headers should be enough:
> This patch header follows DEP-3: http://dep.debian.net/deps/dep3/

quilt header -e --dep3 inserts them by default. I would rather leave them.

> Personally, I wrap debian/watch after the opts line with a
> continuation character ("\").

Agree. Fixed.

> Upstream should probably bump their copyright years, since they worked
> on it in 2016.

I will ping them about it, but upstream is not very prompt on releases.

> Please add some upstream metadata: https://wiki.debian.org/UpstreamMetadata

Okay, added.

> Automatic checks:

There is a lot there, I know. Fixing legacy is ongoing work, but
program is useful right now (I send this email with it)

-- 
Accept: text/plain, text/x-diff
Accept-Language: eo,en,ru
X-Web-Site: sinsekvu.github.io


Reply to: