[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#832704: RFS: nixnote2/2.0~beta8+20160727+ds-1 [ITP] -- Open Source Evernote client



Control: tag -1 -moreinfo
X-Debbugs-CC: debian-mentors@lists.debian.org

2016-08-21 1:02 GMT+08:00 Sean Whitton <spwhitton@spwhitton.name>:
> control: tag -1 +moreinfo
>
> Please don't edit published history -- I wanted to use `git diff` to
> check the changes you had made in response to my review, but now I have
> to just check the whole package from scratch.

Thank you for your advice. I will not force-push commits from now on.

> Could you confirm that https://github.com/hosiet/nixnote2 is the version
> that should be reviewed, please?

Yes. To be more concrete, commit d9e10186a9433a3ca57b8c75427e1926b0164fbc
on branch "debian" is the current debian packaging branch. Commit
b2d66576bb2b9a3c33fa7cc6af69f703082b54d8 on branch master is the
ds-modified upstream source code, and "upstream" branch is the original
upstream release.

> (I can obtain the tarball from mentors, but you might consider adding it
> to your git repository using pristine-tar(1).)

Since it is a debian-source (ds) package, I am not sure which original tarball
should be provided with pristine-tar. Anyway, I put both the ds-modified and
the original tarball with pristine-tar inside now. (Check the
pristine-tar branch.)

FYI, this software is debian-sourced because it used to contain some useless
scripts (custom hacky scripts for deb / rpm / targz packaging) and a jar file
(which is not acceptable in Java packaging). The ds-version merely delete
those files.

The newly-packaged nixnote2 version 2.0~beta9+ds has been pushed onto
https://mentors.debian.net/package/nixnote2 and GitHub, in which the only
change is to enable pristine-tar support.

Thanks and I am still looking forward to further review and sponsorship.

--
Regards,
Boyuan Yang


Reply to: