Bug#733489: Remaining patches for bug #733489
On 09/06/2015 11:48 AM, Julian Andres Klode wrote:
On Sun, Sep 06, 2015 at 11:14:28AM +0200, Michael Schaller wrote:
* You don't need to assign "tvers = self.target_versions" before
the list comprehension, that just reduces readability. Better
split the comprehension over two lines if neede
Done.
* Version.is_installed has no .. versionadded:: 1.0.0
Done.
* The changed __eq__ method might want a
.. versionchanged:: 1.0.0
I've added a docstring to _cmp. This seemed a better idea than adding
docstrings to __eq__, __gt__, ... .
* I don't really understand why you add type comments everywhere.
There are already such comments in other places in the code base and
whenever I use python-apt for projects at work such comments make it
easier for the reviewer to understand what is going on between apt and
apt_pkg. So it's kind of a habit...
Julian, should I remove them?
And I really need the changes documented in doc/source/whatsnew/1.0
add some point, otherwise people do not notice them. But I guess
that's my work, as I still need to add your other changes I merged
there.
Let's finish the current patches and then discuss this topic. I'd
rather avoid making this too chaotic again. ;-)
Reply to: