Bug#733489: Remaining patches for bug #733489
On Wed, Sep 2, 2015 at 10:34 AM, Michael Schaller <michael@5challer.de> wrote:
> Friendly ping to Julian. Julian, do you think we can finish this before
> your University courses start again?
>
Sure. I'm sorry I forgot to send this out, but here we go:
There are some things I don't like currently:
helpers/filter patch:
* The 'for' loops building lists should be comprehensions.
* The early return in is_installed does not make sense, use an 'and' instead
* The 'if' in InstalledFilter.apply should go away, simply return the value.
target_versions patch:
* We cannot simply create a new Package() object, the Cache object keeps
a weak reference to all packages. This needs a slight refactoring by
extracting a
method out of Cache.__getitem__ that creates the apt.Package for the
apt_pkg.Package.
* I'm not sure if Version.__eq__ or whatever should take the name into
consideration,
it probably should, this would remove the need for the hack and the
long comment.
--
Julian Andres Klode - Debian Developer, Ubuntu Member
See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/.
Reply to: