Bug#230159: libapt-pkg-dev: headers contain broken inlines
On Thu, Jan 29, 2004 at 06:46:00PM +0100, Filip Van Raemdonck wrote:
> On Thu, Jan 29, 2004 at 09:06:01AM -0800, Matt Zimmerman wrote:
> > On Thu, Jan 29, 2004 at 06:02:58PM +0100, Filip Van Raemdonck wrote:
> >
> > > On Wed, Jan 28, 2004 at 11:45:08PM -0700, Jason Gunthorpe wrote:
> > >
> > > > TargetVer is obsolete. The thing it used to refer to was removed a long
> > > > time ago, the prototype should also be removed.
> > >
> > > What about putting everything which is deprecated inside ifdefs in apt
> > > 0.6 headers, defaulting to be left out?
> > >
> > > (as this one is already unusable, and hasn't caused problems sofar, it
> > > should just be removed right away)
> >
> > They should either be left out, or implemented (from Jason's comments it
> > sounds like they should be left out). Those #ifdefs would result in
> > different ABIs.
>
> Note that I said "in the headers". The API would vary, but ABI (assuming
> libapt-* would define the symbol to include them so that it builds these
> methods) wouldn't.[1]
> [...]
> [1] However, C++ vtables perhaps do make this an issue?
I thought these were virtual functions, but I suppose they aren't. Maybe
you could get away with this, but what's the point? The functions aren't
there anyway, and programs trying to use them will fail to link, so why
would you leave the declarations in place?
--
- mdz
Reply to: