[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#230159: libapt-pkg-dev: headers contain broken inlines

On Thu, Jan 29, 2004 at 09:06:01AM -0800, Matt Zimmerman wrote:
> On Thu, Jan 29, 2004 at 06:02:58PM +0100, Filip Van Raemdonck wrote:
> > On Wed, Jan 28, 2004 at 11:45:08PM -0700, Jason Gunthorpe wrote:
> > 
> > > TargetVer is obsolete. The thing it used to refer to was removed a long
> > > time ago, the prototype should also be removed.
> > 
> > What about putting everything which is deprecated inside ifdefs in apt
> > 0.6 headers, defaulting to be left out?
> > 
> > (as this one is already unusable, and hasn't caused problems sofar, it
> > should just be removed right away)
> They should either be left out, or implemented (from Jason's comments it
> sounds like they should be left out).  Those #ifdefs would result in
> different ABIs.

Note that I said "in the headers". The API would vary, but ABI (assuming
libapt-* would define the symbol to include them so that it builds these
methods) wouldn't.[1]

Though I wouldn't particularly care about leaving deprecated symbols out
right away in 0.6, it'd be nice to give us some grace period to check what
we would need to change in the various frontends.

Thinking of it, another way would be to already add ifdefs in a new 0.5
upload, but defaulting to a value which does include the deprecated
methods by default to avoid API change. This way we could define the
symbol ourselves to check, and 0.6 could leave things out completely to
clean up the API.

In any case, someone who knows would have to mark what exactly is
deprecated/obsolete, and what isn't... (Jason I guess)



[1] However, C++ vtables perhaps do make this an issue?

Hi! I'm a .signature virus! Copy me into your ~/.signature to help me spread!

Reply to: