[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#489051: Possible patch to solve unresolved symbol



El sáb, 05-07-2008 a las 09:43 +0200, Julien Cristau escribió:
> On Thu, Jul  3, 2008 at 20:19:10 +0200, mariodebian wrote:
> 
> > Hi.
> > 
> > I have made a small patch to solve this bug.
> > 
> > I'm very newbie in this things excuse me if this patch isn't necesary...
> > 
> > I don't know exactly from which version of Xorg this patch applies
> > 
> > #if XORG_VERSION_MAJOR > 1 && XORG_VERSION_MINOR >= 4 &&
> > XORG_VERSION_PATCH > 2
> 
> this is wrong, it won't work if XORG_VERSION_MAJOR is 2 and _MINOR is <
> 4.  needs a comparison between XORG_VERSION_CURRENT and
> XORG_VERSION_NUMERIC(1,4,99,something).

You are true, with my patch Xorg < 2 always use CVTMode, and this is not
my intention....



> 
> >  	mode = xf86GTFMode(p->HDisplay, p->VDisplay, v, 0, 0);
> > #else
> > 	mode = xf86CVTMode(p->HDisplay, p->VDisplay, v, FALSE, FALSE);
> > #endif
> > 
> and I'm not too confident about this, because cvt and gtf modes can't be
> used interchangeably (monitors don't necessarily support both, aiui).
> 


I'm inspired in this commit in xorg last Febrary:

http://lists.freedesktop.org/archives/xorg-commit/2008-February/014985.html

As you see (search GTFMode) the patch when Xorg developers add
xf86GTFMode is very similar to mine, in old versions only use CVTMode.


> Cheers,
> Julien



Greetings

-- 
http://soleup.eup.uva.es/mariodebian

Attachment: signature.asc
Description: Esta parte del mensaje =?ISO-8859-1?Q?est=E1?= firmada digitalmente


Reply to: