Bug#489051: Possible patch to solve unresolved symbol

To: 489051@bugs.debian.org
Subject: Bug#489051: Possible patch to solve unresolved symbol
From: mariodebian <mariodebian@gmail.com>
Date: Thu, 03 Jul 2008 20:19:10 +0200
Message-id: <[🔎] 1215109150.8041.5.camel@thinkpad>
Reply-to: mariodebian <mariodebian@gmail.com>, 489051@bugs.debian.org

Hi.

I have made a small patch to solve this bug.

I'm very newbie in this things excuse me if this patch isn't necesary...

I don't know exactly from which version of Xorg this patch applies

#if XORG_VERSION_MAJOR > 1 && XORG_VERSION_MINOR >= 4 &&
XORG_VERSION_PATCH > 2
 	mode = xf86GTFMode(p->HDisplay, p->VDisplay, v, 0, 0);
#else
	mode = xf86CVTMode(p->HDisplay, p->VDisplay, v, FALSE, FALSE);
#endif

I have used 1.4.2


Attached patch in debdiff format

I have recompiled package and with this patch Xorg starts under
VirtualBox:

# grep VESA /var/log/Xorg.0.log 
(II) VESA: driver for VESA chipsets: vesa
(II) VESA(0): initializing int10
(II) VESA(0): Primary V_BIOS segment is: 0xc000
(II) VESA(0): VESA BIOS detected
(II) VESA(0): VESA VBE Version 2.0
(II) VESA(0): VESA VBE Total Mem: 4096 kB
(II) VESA(0): VESA VBE OEM: VirtualBox VBE BIOS
http://www.virtualbox.org/
(II) VESA(0): VESA VBE OEM Software Rev: 0.2
(II) VESA(0): VESA VBE OEM Vendor: Sun Microsystems, Inc.
(II) VESA(0): VESA VBE OEM Product: VirtualBox VBE Adapter
(II) VESA(0): VESA VBE OEM Product Rev: Sun xVM VirtualBox Version
1.6.2_OSE
(**) VESA(0): Depth 16, (--) framebuffer bpp 16
(==) VESA(0): RGB weight 565
(==) VESA(0): Default visual is TrueColor
(==) VESA(0): Using gamma correction (1.0, 1.0, 1.0)
(II) VESA(0): VESA VBE DDC not supported
(II) VESA(0): Searching for matching VESA mode(s):
(II) VESA(0): Total Memory: 64 64KB banks (4096kB)
(II) VESA(0): Generic Monitor: Using hsync range of 28.00-49.00 kHz
(II) VESA(0): Generic Monitor: Using vrefresh range of 43.00-72.00 Hz
(II) VESA(0): Not using built-in mode "1024x768" (no mode of this name)
(II) VESA(0): Not using mode "1024x768" (no mode of this name)
(II) VESA(0): Not using built-in mode "800x600" (no mode of this name)
(II) VESA(0): Not using built-in mode "640x480" (no mode of this name)
(II) VESA(0): Not using built-in mode "1280x1024" (no mode of this name)
(II) VESA(0): Not using built-in mode "1152x864" (no mode of this name)
(II) VESA(0): Not using built-in mode "320x200" (no mode of this name)
(WW) VESA(0): No valid modes left.  Trying less strict filter...
(II) VESA(0): Generic Monitor: Using hsync range of 28.00-49.00 kHz
(II) VESA(0): Generic Monitor: Using vrefresh range of 43.00-72.00 Hz
(II) VESA(0): Not using mode "1024x768" (no mode of this name)
(II) VESA(0): Not using built-in mode "1280x1024" (width too large for
virtual size)
(II) VESA(0): Not using built-in mode "1152x864" (width too large for
virtual size)
(II) VESA(0): Not using built-in mode "320x200" (hsync out of range)
(--) VESA(0): Virtual size is 1024x768 (pitch 1024)
(**) VESA(0): *Built-in mode "1024x768"
(**) VESA(0): *Built-in mode "800x600"
(**) VESA(0): *Built-in mode "640x480"
(==) VESA(0): DPI set to (96, 96)
(II) VESA(0): Attempting to use 60Hz refresh for mode "1024x768" (117)
(II) VESA(0): Attempting to use 72Hz refresh for mode "800x600" (114)
(II) VESA(0): Attempting to use 60Hz refresh for mode "640x480" (111)
(**) VESA(0): Using "Shadow Framebuffer"
(II) VESA(0): initializing int10
(II) VESA(0): Primary V_BIOS segment is: 0xc000
(II) VESA(0): VESA BIOS detected
(II) VESA(0): VESA VBE Version 2.0
(II) VESA(0): VESA VBE Total Mem: 4096 kB
(II) VESA(0): VESA VBE OEM: VirtualBox VBE BIOS
http://www.virtualbox.org/
(II) VESA(0): VESA VBE OEM Software Rev: 0.2
(II) VESA(0): VESA VBE OEM Vendor: Sun Microsystems, Inc.
(II) VESA(0): VESA VBE OEM Product: VirtualBox VBE Adapter
(II) VESA(0): VESA VBE OEM Product Rev: Sun xVM VirtualBox Version
1.6.2_OSE
(II) VESA(0): virtual address = 0xb75a1000,
(==) VESA(0): Default visual is TrueColor
(==) VESA(0): Backing store disabled
(**) VESA(0): DPMS enabled

Xrandr seems to work ok.


Thank you for your work at Debian.

Greetings
-- 
http://soleup.eup.uva.es/mariodebian

diff -u xserver-xorg-video-vesa-2.0.0/debian/changelog xserver-xorg-video-vesa-2.0.0/debian/changelog
--- xserver-xorg-video-vesa-2.0.0/debian/changelog
+++ xserver-xorg-video-vesa-2.0.0/debian/changelog
@@ -1,3 +1,11 @@
+xserver-xorg-video-vesa (1:2.0.0-1.1) unstable; urgency=low
+
+  * Add patch: 10_disable_gtfmode
+    - Use xf86CVTMode instead of xf86GTFMode in old versions of Xorg
+    - Add quilt to BuildDepends
+
+ -- Mario Izquierdo (mariodebian) <mariodebian@gmail.com>  Thu, 03 Jul 2008 19:54:43 +0200
+
 xserver-xorg-video-vesa (1:2.0.0-1) unstable; urgency=low
 
   * New upstream release.
diff -u xserver-xorg-video-vesa-2.0.0/debian/control xserver-xorg-video-vesa-2.0.0/debian/control
--- xserver-xorg-video-vesa-2.0.0/debian/control
+++ xserver-xorg-video-vesa-2.0.0/debian/control
@@ -3,7 +3,7 @@
 Priority: optional
 Maintainer: Debian X Strike Force <debian-x@lists.debian.org>
 Uploaders: David Nusinow <dnusinow@debian.org>, Branden Robinson <branden@debian.org>
-Build-Depends: debhelper (>= 5.0.0), pkg-config, xserver-xorg-dev (>= 2:1.4), x11proto-xext-dev, x11proto-core-dev, x11proto-fonts-dev, x11proto-randr-dev, x11proto-render-dev, dpkg-dev (>= 1.14.17)
+Build-Depends: debhelper (>= 5.0.0), pkg-config, xserver-xorg-dev (>= 2:1.4), x11proto-xext-dev, x11proto-core-dev, x11proto-fonts-dev, x11proto-randr-dev, x11proto-render-dev, dpkg-dev (>= 1.14.17), quilt
 Standards-Version: 3.7.3
 Vcs-Git: git://git.debian.org/git/pkg-xorg/driver/xserver-xorg-video-vesa
 Vcs-Browser: http://git.debian.org/?p=pkg-xorg/driver/xserver-xorg-video-vesa.git
diff -u xserver-xorg-video-vesa-2.0.0/debian/rules xserver-xorg-video-vesa-2.0.0/debian/rules
--- xserver-xorg-video-vesa-2.0.0/debian/rules
+++ xserver-xorg-video-vesa-2.0.0/debian/rules
@@ -32,7 +32,7 @@
 confflags += --disable-static
 
 build: build-stamp
-build-stamp:
+build-stamp: patch
 	dh_testdir
 
 	test -d obj-$(DEB_BUILD_GNU_TYPE) || mkdir obj-$(DEB_BUILD_GNU_TYPE)
@@ -44,7 +44,7 @@
 
 	touch build-stamp
 
-clean:
+clean: unpatch
 	dh_testdir
 	dh_testroot
 	rm -f build-stamp
@@ -56,6 +56,7 @@
 	rm -rf obj-*
 
 	dh_clean
+	rm -rf stampdir
 
 install: build
 	dh_testdir
--- xserver-xorg-video-vesa-2.0.0.orig/debian/patches/10_disable_gtfmode
+++ xserver-xorg-video-vesa-2.0.0/debian/patches/10_disable_gtfmode
@@ -0,0 +1,16 @@
+diff -urNad xserver-xorg-video-vesa-2.0.0~/src/vesa.c xserver-xorg-video-vesa-2.0.0/src/vesa.c
+--- xserver-xorg-video-vesa-2.0.0~/src/vesa.c	2008-07-01 19:40:04.000000000 +0200
++++ xserver-xorg-video-vesa-2.0.0/src/vesa.c	2008-07-03 19:36:44.000000000 +0200
+@@ -342,7 +342,11 @@
+      * then, by this point, you're well into despair territory.
+      */
+     for (v = mon->vrefresh[0].lo; v <= mon->vrefresh[0].hi; v++) {
++#if XORG_VERSION_MAJOR > 1 && XORG_VERSION_MINOR >= 4 && XORG_VERSION_PATCH > 2
+ 	mode = xf86GTFMode(p->HDisplay, p->VDisplay, v, 0, 0);
++#else
++	mode = xf86CVTMode(p->HDisplay, p->VDisplay, v, FALSE, FALSE);
++#endif
+ 	ret = xf86CheckModeForMonitor(mode, mon);
+ 	xfree(mode);
+ 	if (ret == MODE_OK)
only in patch2:
unchanged:
--- xserver-xorg-video-vesa-2.0.0.orig/debian/patches/series
+++ xserver-xorg-video-vesa-2.0.0/debian/patches/series
@@ -0,0 +1 @@
+10_disable_gtfmode

Attachment: signature.asc
Description: Esta parte del mensaje =?ISO-8859-1?Q?est=E1?= firmada digitalmente

Reply to:

Follow-Ups:
- Bug#489051: Possible patch to solve unresolved symbol
  - From: Brice Goglin <Brice.Goglin@ens-lyon.org>
- Bug#489051: Possible patch to solve unresolved symbol
  - From: Julien Cristau <jcristau@debian.org>

Prev by Date: mesa: Changes to 'debian-experimental'
Next by Date: Bug#489232: xfs: missing syslog dependency in init script
Previous by thread: xserver-xorg-video-via_0.2.2-6_i386.changes ACCEPTED
Next by thread: Bug#489051: Possible patch to solve unresolved symbol
Index(es):
- Date
- Thread